Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Await for responseHeadersTask to observe exception if any #38358

Closed
wfurt wants to merge 1 commit into from
Closed

Await for responseHeadersTask to observe exception if any #38358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,6 +1399,8 @@ public sealed override async Task<HttpResponseMessage> SendAsync(HttpRequestMess
}
else
{
await responseHeadersTask;
Copy link
Copy Markdown
Member

@JamesNK JamesNK Jun 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment explaining why (like what you said in the issue)

😄


Copy link
Copy Markdown
Member

@stephentoub stephentoub Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the await be moved down to below the ContinueWith and nulling out below?

// We received the response headers but the request body hasn't yet finished.
// If the connection is aborted or if we get RST or GOAWAY from server, exception will be
// stored in stream._abortException and propagated to up to caller if possible while processing response.
Expand Down