Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[WIP] Update APICompat baselines#39033

Closed
wtgodbe wants to merge 1 commit intodotnet:masterfrom
wtgodbe:Baseline
Closed

[WIP] Update APICompat baselines#39033
wtgodbe wants to merge 1 commit intodotnet:masterfrom
wtgodbe:Baseline

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented Jun 28, 2019

I got this by building once per-framework, and modifying shims.proj so that it writes to the baseline files rather than comparing against them. I remember there being some weirdness with that process, so I'm putting this up to see if CI complains before I look further.

@ericstj
Copy link
Copy Markdown
Member

ericstj commented Jun 28, 2019

@wtgodbe why wouldn't these diffs have been causing APICompat failures before?

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 28, 2019

@ericstj it looks like this just added a bunch of duplicates for some reason. I reduced ApiCompatBaseline.netcoreapp.netstandard.txt to just unique lines in Sublime, and it winds up being 2 lines shorter than the same in master. Not sure why that's happening yet.

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 28, 2019

https://github.com/dotnet/corefx/pull/39033/files#diff-3093ac31dad3463a99acc3f2de5a439aL67 (and the next 2) appear to be the only real removals to ApiCompatBaseline.netcoreapp.netstandard.txt, while all the additions are duplicates. Presumably this is due to dotnet/standard#1181

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 28, 2019

Removals from ApiCompatBaseline.netcoreapp.netstandardOnly.txt are legit, and are due to dotnet/standard#1222

@ericstj
Copy link
Copy Markdown
Member

ericstj commented Jun 28, 2019

Yeah, I'm not worried about removals, that's cleanup. Additions indicate new problems that I would have expected to fail the build.

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jul 9, 2019

Closing in favor of #39346

@wtgodbe wtgodbe closed this Jul 9, 2019
@wtgodbe wtgodbe deleted the Baseline branch July 9, 2019 23:07
@karelz karelz added this to the 3.0 milestone Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants