Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Move WithCancellation/ConfigureAwait extension methods to TaskAsyncEnumerableExtensions#1181

Merged
terrajobst merged 1 commit intodotnet:masterfrom
joperezr:TaskAsyncEnumerableExtensions
May 9, 2019
Merged

Move WithCancellation/ConfigureAwait extension methods to TaskAsyncEnumerableExtensions#1181
terrajobst merged 1 commit intodotnet:masterfrom
joperezr:TaskAsyncEnumerableExtensions

Conversation

@joperezr
Copy link
Copy Markdown
Member

@joperezr joperezr commented May 9, 2019

cc: @stephentoub @terrajobst

Responding to changes made by dotnet/corefx#37367 where the extnsion methods where moved to a new type. This is the first time I make a change like this so please do let me know if I missed anything.

@joperezr joperezr requested review from stephentoub and terrajobst May 9, 2019 18:21
@joperezr joperezr requested review from a team as code owners May 9, 2019 18:21
@terrajobst terrajobst added the netstandard-api This tracks requests for standardizing APIs. label May 9, 2019
@terrajobst terrajobst added this to the .NET Standard 2.1 milestone May 9, 2019
@terrajobst
Copy link
Copy Markdown

This is the first time I make a change like this so please do let me know if I missed anything.

I usually set the netstandard-api label for API related changes in .NET Standard and I also set a milestone. But this looks good as is.

@dotnet/nsboard This a change we need to take in order to react to an API change that we needed to make in CoreFX where IAsyncEnumerable<T> came from. I've removed the board because the API was previously signed off already.

@terrajobst terrajobst removed request for a team May 9, 2019 18:41
@jskeet
Copy link
Copy Markdown

jskeet commented May 9, 2019

So just to be clear, this isn't a change from netstandard2.0 - it's changing methods/classes that have been added since netstandard2.0?

@stephentoub
Copy link
Copy Markdown
Member

stephentoub commented May 9, 2019

it's changing methods/classes that have been added since netstandard2.0?

Correct. These new methods were added in netstandard2.1, just to an existing type, and they're being moved to a new type instead.

Copy link
Copy Markdown

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure about the new class name, but my understanding is that this PR isn't really deciding that - it's just reflecting a decision made elsewhere, which I don't want to try to relitigate :)

@terrajobst terrajobst merged commit b77bbe5 into dotnet:master May 9, 2019
@joperezr joperezr deleted the TaskAsyncEnumerableExtensions branch May 9, 2019 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

netstandard-api This tracks requests for standardizing APIs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants