This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Reconfigure terminal for Console usage even if only one of stdin/stdout was used by the child#40563
Merged
stephentoub merged 2 commits intodotnet:masterfrom Aug 27, 2019
Merged
Conversation
…f only one of stdin/stdout was used by the child. Console: Unix: Fix cache check for VTIME (read timeout). Fixes https://github.com/dotnet/corefx/issues/40557
Member
Author
stephentoub
reviewed
Aug 26, 2019
stephentoub
approved these changes
Aug 26, 2019
Member
|
@SteveL-MSFT, can you please confirm this fixes your issue(s)? |
Member
|
@SteveL-MSFT told me offline that he'll help validate this today. |
|
Can confirm this fixes #40557 and doesn't introduce new issues with our tests. Thanks! |
Member
|
Thanks, @SteveL-MSFT. |
tmds
commented
Aug 28, 2019
| bool usesTerminal = !startInfo.RedirectStandardInput && !startInfo.RedirectStandardOutput; | ||
| bool usesTerminal = !(startInfo.RedirectStandardInput && | ||
| startInfo.RedirectStandardOutput && | ||
| startInfo.RedirectStandardError); |
Member
Author
There was a problem hiding this comment.
for reference, discussion whether we should include RedirectStandardError here: 4b35a6f#r34854614
stephentoub
pushed a commit
to stephentoub/corefx
that referenced
this pull request
Aug 28, 2019
…ut was used by the child (dotnet#40563)
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ut was used by the child (dotnet/corefx#40563) * Process: Unix: ensure we reconfigure the terminal for Console usage if only one of stdin/stdout was used by the child. Console: Unix: Fix cache check for VTIME (read timeout). Fixes https://github.com/dotnet/corefx/issues/40557 * Also consider not redirecting stderr as terminal usage Commit migrated from dotnet/corefx@4b35a6f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process: Unix: ensure we reconfigure the terminal for Console usage if only one of stdin/stdout was used by the child.
Console: Unix: Fix cache check for VTIME (read timeout).
Fixes https://github.com/dotnet/corefx/issues/40557