Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Reconfigure terminal for Console usage even if only one of stdin/stdout was used by the child #40563

Merged
stephentoub merged 2 commits into from
Aug 27, 2019
Merged

Reconfigure terminal for Console usage even if only one of stdin/stdout was used by the child #40563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ba6707
Process: Unix: ensure we reconfigure the terminal for Console usage i…
tmds Aug 24, 2019
1cb31eb
Also consider not redirecting stderr as terminal usage
tmds Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Native/Unix/System.Native/pal_console.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ static bool ConfigureTerminal(bool signalForBreak, bool forChild, uint8_t minCha
if (g_currentTermios.c_lflag == termios.c_lflag &&
g_currentTermios.c_iflag == termios.c_iflag &&
g_currentTermios.c_cc[VMIN] == termios.c_cc[VMIN] &&
g_currentTermios.c_cc[VMIN] == termios.c_cc[VMIN])
g_currentTermios.c_cc[VTIME] == termios.c_cc[VTIME])
{
return true;
}
Expand Down
5 changes: 3 additions & 2 deletions src/System.Diagnostics.Process/src/System/Diagnostics/Process.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,9 @@ private bool StartCore(ProcessStartInfo startInfo)
// Unix applications expect the terminal to be in an echoing state by default.
// To support processes that interact with the terminal (e.g. 'vi'), we need to configure the
// terminal to echo. We keep this configuration as long as there are children possibly using the terminal.
// We consider the child to be interactively using the terminal when both stdin and stdout are connected.
bool usesTerminal = !startInfo.RedirectStandardInput && !startInfo.RedirectStandardOutput;
bool usesTerminal = !(startInfo.RedirectStandardInput &&
startInfo.RedirectStandardOutput &&
startInfo.RedirectStandardError);
Copy link
Copy Markdown
Member Author

@tmds tmds Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference, discussion whether we should include RedirectStandardError here: 4b35a6f#r34854614


if (startInfo.UseShellExecute)
{
Expand Down