This repository was archived by the owner on Jan 23, 2023. It is now read-only.
System.Linq: Genericize ToDictionary optimizations for IList<T>#5261
Closed
jamesqo wants to merge 1 commit intodotnet:masterfrom
Closed
System.Linq: Genericize ToDictionary optimizations for IList<T>#5261jamesqo wants to merge 1 commit intodotnet:masterfrom
jamesqo wants to merge 1 commit intodotnet:masterfrom
Conversation
Also removed no-longer needed array overloads and replaced `foreach` with `for`.
jamesqo
changed the title
Member
|
You say "optimizations", but at first glance I'd expect the changes you've made would actually harm performance, e.g. accessing an array is slower when done via an interface. Please share your performance tests and results. Thanks. |
Contributor
|
This change will definitely lead to a perf regression for both For the other collections that implement In any case, the performance tests are required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed no-longer needed array overloads and replaced
foreachwithfor.