Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

System.Linq: Genericize ToDictionary optimizations for IList<T> #5261

Closed
jamesqo wants to merge 1 commit into from
Closed

System.Linq: Genericize ToDictionary optimizations for IList<T> #5261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 8 additions & 27 deletions src/System.Linq/src/System/Linq/Enumerable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,10 +1293,7 @@ public static Dictionary<TKey, TSource> ToDictionary<TSource, TKey>(this IEnumer
if (capacity == 0)
return new Dictionary<TKey, TSource>(comparer);

TSource[] array = collection as TSource[];
if (array != null)
return ToDictionary(array, keySelector, comparer);
List<TSource> list = collection as List<TSource>;
IList<TSource> list = collection as IList<TSource>;
if (list != null)
return ToDictionary(list, keySelector, comparer);
}
Expand All @@ -1305,21 +1302,14 @@ public static Dictionary<TKey, TSource> ToDictionary<TSource, TKey>(this IEnumer
foreach (TSource element in source) d.Add(keySelector(element), element);
return d;
}

private static Dictionary<TKey, TSource> ToDictionary<TSource, TKey>(TSource[] source, Func<TSource, TKey> keySelector, IEqualityComparer<TKey> comparer)
{
Dictionary<TKey, TSource> d = new Dictionary<TKey, TSource>(source.Length, comparer);
for (int i = 0; i < source.Length; i++) d.Add(keySelector(source[i]), source[i]);
return d;
}
private static Dictionary<TKey, TSource> ToDictionary<TSource, TKey>(List<TSource> source, Func<TSource, TKey> keySelector, IEqualityComparer<TKey> comparer)

private static Dictionary<TKey, TSource> ToDictionary<TSource, TKey>(IList<TSource> source, Func<TSource, TKey> keySelector, IEqualityComparer<TKey> comparer)
{
Dictionary<TKey, TSource> d = new Dictionary<TKey, TSource>(source.Count, comparer);
foreach (TSource element in source) d.Add(keySelector(element), element);
for (int i = 0; i < source.Count; i++) d.Add(keySelector(source[i]), source[i]);
return d;
}


public static Dictionary<TKey, TElement> ToDictionary<TSource, TKey, TElement>(this IEnumerable<TSource> source, Func<TSource, TKey> keySelector, Func<TSource, TElement> elementSelector)
{
return ToDictionary<TSource, TKey, TElement>(source, keySelector, elementSelector, null);
Expand All @@ -1339,10 +1329,7 @@ public static Dictionary<TKey, TElement> ToDictionary<TSource, TKey, TElement>(t
if (capacity == 0)
return new Dictionary<TKey, TElement>(comparer);

TSource[] array = collection as TSource[];
if (array != null)
return ToDictionary(array, keySelector, elementSelector, comparer);
List<TSource> list = collection as List<TSource>;
IList<TSource> list = collection as IList<TSource>;
if (list != null)
return ToDictionary(list, keySelector, elementSelector, comparer);
}
Expand All @@ -1351,17 +1338,11 @@ public static Dictionary<TKey, TElement> ToDictionary<TSource, TKey, TElement>(t
foreach (TSource element in source) d.Add(keySelector(element), elementSelector(element));
return d;
}

private static Dictionary<TKey, TElement> ToDictionary<TSource, TKey, TElement>(TSource[] source, Func<TSource, TKey> keySelector, Func<TSource, TElement> elementSelector, IEqualityComparer<TKey> comparer)
{
Dictionary<TKey, TElement> d = new Dictionary<TKey, TElement>(source.Length, comparer);
for (int i = 0; i < source.Length; i++) d.Add(keySelector(source[i]), elementSelector(source[i]));
return d;
}
private static Dictionary<TKey, TElement> ToDictionary<TSource, TKey, TElement>(List<TSource> source, Func<TSource, TKey> keySelector, Func<TSource, TElement> elementSelector, IEqualityComparer<TKey> comparer)

private static Dictionary<TKey, TElement> ToDictionary<TSource, TKey, TElement>(IList<TSource> source, Func<TSource, TKey> keySelector, Func<TSource, TElement> elementSelector, IEqualityComparer<TKey> comparer)
{
Dictionary<TKey, TElement> d = new Dictionary<TKey, TElement>(source.Count, comparer);
foreach (TSource element in source) d.Add(keySelector(element), elementSelector(element));
for (int i = 0; i < source.Count; i++) d.Add(keySelector(source[i]), elementSelector(source[i]));
return d;
}

Expand Down