This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Introducing native shims for libgssapi in order to support NegotiateStream#5774
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
This supercedes #5500 |
Contributor
|
Adding reference to #2483 |
Contributor
Author
|
bartonjs :
This is fixed. Thanks. |
Member
There was a problem hiding this comment.
Needs the new license headers on all new files.
Member
There was a problem hiding this comment.
This ctor seems like it's only used by the previous ctor, and if it is used by other code, we'd end up not including majorStatus and minorStatus in the error message. Seems like it'd be better to do away with this ctor entirely and just have the previous one be:
public GssApiException(Status majorStatus, Status minorStatus) :
base(SR.Format(SR.net_gssapi_operation_failed, majorstatus, minorStatus))
{
HResult = (int)majorStatus;
_minorStatus = minorStatus;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing native shims for libgssapi in order to support NegotiateStream