Modify Outerloop job in groovy to run on Ubuntu and Windows. by Priya91 · Pull Request #6028 · dotnet/corefx

Priya91 · 2016-02-11T01:04:52Z

cc @mmitche @joshfree @rahulkotecha @vijaykota

Priya91 · 2016-02-11T01:07:52Z

@dotnet-bot Test OuterLoop Ubuntu Debug

joshfree · 2016-02-11T01:16:14Z

@@ -0,0 +1,97 @@
+#!/bin/bash
+
+OS=`cat /etc/os-release | grep "PRETTY_NAME" | sed 's/PRETTY_NAME=//g' | sed 's/["]//g' | awk '{print $1}'`


Why parse PRETTY_NAME when you can just read ID from os-release?

@rahulkotecha Can you please address the PR comments on networking scripts. Thanks!

Sure.. Rahul can take care of all these changes when he sends his PR with the updates required for other distros as well

took care of these changes and changes required for other Linux distros as part of: rahulkotecha-zz@e8acf95
Thanks!

Priya91 · 2016-02-11T05:55:35Z

Need dotnet/dotnet-ci#164 to test the ubuntu outerloop changes.

Priya91 · 2016-02-11T19:01:52Z

@dotnet-bot Test OuterLoop Ubuntu Debug

mmitche · 2016-02-11T19:10:42Z

@Priya91 Your netci changes will not affect any runs here. This will need to be merged first.

Question: Are there implications of running multiple runs on the same machine at the same time here?

Priya91 · 2016-02-11T19:14:49Z

@mmitche Yes we don't want to do that. But we run only one run per machine at a time right?

Priya91 · 2016-02-11T19:15:44Z

Also it would be best if we can bring this setup step further down below to xunit setup, as these tests will surely fail on local outerloop dev box runs.

mmitche · 2016-02-11T19:16:16Z

In the auto-images, yes

mmitche · 2016-02-11T19:17:21Z


-def osShortName = ['Windows 10': 'win10', 'Windows 7' : 'win7', 'Windows_NT' : 'windows_nt']
+def osShortName = ['Windows 10': 'win10', 'Windows 7' : 'win7', 'Windows_NT' : 'windows_nt', 'Ubuntu' : 'ubuntu']
+def outerloopOSs = ['Windows 10', 'Windows 7', 'Windows_NT', 'Ubuntu']


Can you change this to Ubuntu14.04 to be more specific (since we have 15.10 now too)

mmitche · 2016-02-11T19:17:42Z

LGTM besides the minor comment.

Priya91 · 2016-02-12T03:46:59Z

@mmitche Incorporated the 14.04 changes. @rahulkotecha @vijaykota Can you please check if executing the script as a test class initialization works? I have created a fixture template for it to test, or would you prefer it to be in jenkins setup ?

cc @joshfree

vijaykota · 2016-02-12T06:33:08Z

Can you please check if executing the script as a test class initialization works

We will try this out. I believe this should work since the Jenkins user now has sudo perms.

LGTM for Priya's changes. Thanks!

stephentoub · 2016-02-12T12:31:11Z

@dotnet-bot test this please

joshfree · 2016-02-12T17:53:32Z

The test initialization needs to be separate from Jenkins infrastructure - so that developers can execute the test outside of a Jenkins CI environment.

Priya91 · 2016-02-12T18:50:41Z

This needs dotnet/dotnet-ci#173 before merge.

Priya91 · 2016-02-12T18:51:57Z

The Outerloop ubuntu/OSX tests are failing because they are not being run sudo. The netci.groovy changes in the PR are not used for PR testing. These changes will be reflected after merge.

Priya91 · 2016-02-12T23:26:35Z

@dotnet-bot test this please

kapilash · 2016-02-15T13:26:39Z

@Priya91

Can you please check if executing the script as a test class initialization works? I have created a fixture template for it to test, or would you prefer it to be in jenkins setup ?

I tried running it as a fixture, but could not succeed. I need to execute the script as a super user, otherwise it would fail to install the required packages or setup the KDC.

But trying to run the tests as super user via sudo ./corerun xunit.console.exe <dll-name> results in coreclr_initialize failed - status: 0x8007001f

I could be wrong but this seems to have something to do with the permissions of the assemblies that are generated using our build.

Is there any reason to expect that this issue would not occur on CI machines?

Priya91 · 2016-02-16T19:07:58Z

@kapilash The script does not have to be run as sudo, since I have made the individual instructions in the script that need to be elevated as sudo. Or if the whole script has to be sudo then there can be a wrapper to run it as sudo setup-kdc.sh from the wrapper script.

Regarding the coreclr_initialize failed, that is not related to these changes. Seems like coreclr package was not found.

Priya91 · 2016-02-16T22:09:28Z

Have pushed the wrong branch tracking master. fixing this.

Initial KDC setup script (tested on ubuntu)

Configuration files for the KDC setup (tested on ubuntu)

Execute kdc script has a test class initialization step. Conflicts: src/System.Net.Security/tests/FunctionalTests/unix/project.json

Priya91 · 2016-02-16T23:56:41Z

15:30:26 Mismatch : expected: <Root><!--test - - --></Root>
15:30:26  actual: <Root>
15:30:26   <!--test - - -->
15:30:26 </Root>
15:30:26 Mismatch : expected: <Root><?badpi text ? >?></Root>
15:30:26  actual: <Root>
15:30:26   <?badpi text ? >?>
15:30:26 </Root>
15:30:26 Mismatch : expected: <Root><![CDATA[test ]]]]><![CDATA[> test]]></Root>
15:30:26  actual: <Root><![CDATA[test ]]]]><![CDATA[> test]]></Root>

@dotnet-bot Test Innerloop Ubuntu Release Build and Test

Priya91 · 2016-02-17T00:10:32Z

16:01:57 d:\j\workspace\dotnet_corefx\osx_release_bld_prtest>call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x86   && build.cmd /p:ConfigurationGroup=Release /p:OSGroup=OSX /p:SkipTests=true /p:TestNugetRuntimeId=osx.10.10-x64 
16:01:57 Installing dotnet cli...
16:02:08 Restoring BuildTools version 1.0.25-prerelease-00165...
16:07:09 Error: FindPackagesById: Microsoft.DotNet.BuildTools
16:07:09   HTTP request timed out. Exiting.
16:07:09 ERROR: Could not restore build tools correctly. See 'd:\j\workspace\dotnet_corefx\osx_release_bld_prtest\init-tools.log' for more details.

Priya91 · 2016-02-17T01:04:42Z

@dotnet-bot test this please

Priya91 · 2016-02-17T02:09:32Z

Test failures due to #6153 in OSX and Ubuntu

Priya91 · 2016-02-17T02:16:55Z

@dotnet-bot Test Innerloop OSX Release Build and Test

Priya91 · 2016-02-17T02:17:18Z

@dotnet-bot Test Innerloop Ubuntu Release Build and Test

Priya91 · 2016-02-17T05:03:02Z

@dotnet-bot Test Innerloop Ubuntu Release Build and Test

weshaggard · 2016-02-17T05:33:48Z

 // Globals

+// List of all CI OS
+def allOSs = ['Ubuntu', 'Debian8.2', 'OSX', 'FreeBSD', 'CentOS7.1', 'OpenSUSE13.2', 'Windows 10', 'Windows 7', 'Windows_NT']


Where is this used? Perhaps I missed it but I don't see it used in the script anywhere.

This is not used anywhere currently, but will be used when all OSes are supported in Outerloop. Will remove the def Outerloop then. Sorry your comment didnt update on my client.. Saw this only now.

Modify Outerloop job in groovy to run on Ubuntu and Windows.

dnfclas added the cla-already-signed label Feb 11, 2016

Priya91 added 2 - In Progress and removed cla-already-signed labels Feb 11, 2016

joshfree reviewed Feb 11, 2016
View reviewed changes

Priya91 force-pushed the negotiatestream branch from 9734d8f to d7afbc9 Compare February 11, 2016 06:00

mmitche reviewed Feb 11, 2016
View reviewed changes

Priya91 force-pushed the negotiatestream branch from d7afbc9 to 766ad3f Compare February 12, 2016 03:43

Priya91 force-pushed the negotiatestream branch from 766ad3f to ee0d83e Compare February 12, 2016 18:53

Priya91 force-pushed the negotiatestream branch from ee0d83e to 2ffb80f Compare February 16, 2016 22:03

Priya91 force-pushed the negotiatestream branch from 2ffb80f to c27679d Compare February 16, 2016 22:21

KDC setup script

cfa8a01

Initial KDC setup script (tested on ubuntu)

KDC Setup script

1ec6ed9

Configuration files for the KDC setup (tested on ubuntu)

Priya91 force-pushed the negotiatestream branch from c27679d to e24db70 Compare February 16, 2016 22:26

Priya91 mentioned this pull request Feb 16, 2016

NegotiateStream Tests on Unix #6139

Merged

Modify Outerloop job to run on Ubuntu.

2e62dde

Execute kdc script has a test class initialization step. Conflicts: src/System.Net.Security/tests/FunctionalTests/unix/project.json

Priya91 force-pushed the negotiatestream branch from a6fda4a to 2e62dde Compare February 16, 2016 22:57

weshaggard reviewed Feb 17, 2016
View reviewed changes

Priya91 added a commit that referenced this pull request Feb 17, 2016

Merge pull request #6028 from Priya91/negotiatestream

013d0c0

Modify Outerloop job in groovy to run on Ubuntu and Windows.

Priya91 merged commit 013d0c0 into dotnet:dev/negotiatestream Feb 17, 2016

Priya91 removed the 2 - In Progress label Feb 17, 2016

Priya91 deleted the negotiatestream branch March 1, 2016 22:09

karelz added this to the 1.0.0-rtm milestone Jan 21, 2017

karelz added the area-System.Net label Jan 21, 2017

		@@ -0,0 +1,97 @@
		#!/bin/bash

		OS=`cat /etc/os-release \| grep "PRETTY_NAME" \| sed 's/PRETTY_NAME=//g' \| sed 's/["]//g' \| awk '{print $1}'`

Conversation

Priya91 commented Feb 11, 2016

Uh oh!

Priya91 commented Feb 11, 2016

Uh oh!

joshfree Feb 11, 2016

Choose a reason for hiding this comment

Uh oh!

Priya91 Feb 11, 2016

Choose a reason for hiding this comment

Uh oh!

vijaykota Feb 12, 2016

Choose a reason for hiding this comment

Uh oh!

rahulkotecha-zz Feb 12, 2016

Choose a reason for hiding this comment

Uh oh!

Priya91 commented Feb 11, 2016

Uh oh!

Priya91 commented Feb 11, 2016

Uh oh!

mmitche commented Feb 11, 2016

Uh oh!

Priya91 commented Feb 11, 2016

Uh oh!

Priya91 commented Feb 11, 2016

Uh oh!

mmitche commented Feb 11, 2016

Uh oh!

mmitche Feb 11, 2016

Choose a reason for hiding this comment

Uh oh!

mmitche commented Feb 11, 2016

Uh oh!

Priya91 commented Feb 12, 2016

Uh oh!

vijaykota commented Feb 12, 2016

Uh oh!

stephentoub commented Feb 12, 2016

Uh oh!

joshfree commented Feb 12, 2016

Uh oh!

Priya91 commented Feb 12, 2016

Uh oh!

Priya91 commented Feb 12, 2016

Uh oh!

Priya91 commented Feb 12, 2016

Uh oh!

kapilash commented Feb 15, 2016

Uh oh!

Priya91 commented Feb 16, 2016

Uh oh!

Priya91 commented Feb 16, 2016

Uh oh!

Priya91 commented Feb 16, 2016

Uh oh!

Priya91 commented Feb 17, 2016

Uh oh!

Priya91 commented Feb 17, 2016

Uh oh!

Priya91 commented Feb 17, 2016

Uh oh!

Priya91 commented Feb 17, 2016

Uh oh!

Priya91 commented Feb 17, 2016

Uh oh!

Priya91 commented Feb 17, 2016

Uh oh!

weshaggard Feb 17, 2016

Choose a reason for hiding this comment

Uh oh!

Priya91 Feb 17, 2016

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development