NegotiateStream Tests on Unix by kapilash · Pull Request #6139 · dotnet/corefx

kapilash · 2016-02-16T18:16:30Z

Introducing CI tests for NegotiateStream on Unix.

This PR is introduced as two commits -

where the infrastructure setup (related to installing and configuring kdc) is done as a part of external script (that is run by the jenkins job).

2)where the setup is done via a test fixture.

In order for the tests to run successfully, #5773 needs to be merged.

stephentoub · 2016-02-16T20:51:24Z

+
+
+    GssBuffer inputToken {.length = UnsignedCast(inputLength), .value = inputBytes};
+    GssBuffer gssBuffer { .length = 0, .value = nullptr };


Nits: a few formatting things, e.g. extra blank line above, the two initializers not having the same spacing around the fields, etc.

Priya91 · 2016-02-16T22:49:19Z

With the fixture setup done here, will remove the sample code from #6028

stephentoub · 2016-02-17T02:06:06Z

+                                                     struct PAL_GssBuffer* outBuffer);
+
+/*
+


Nit: similar formatting nits, e.g. blank line, function arguments not aligned, etc.

stephentoub · 2016-02-17T04:05:50Z

Looks like a good start. Thanks!

vijaykota · 2016-02-17T06:34:50Z

This PR depends on #6158 in addition to #5773.

vijaykota · 2016-02-17T06:36:52Z

+
+        [Fact, OuterLoop]
+        [PlatformSpecific(PlatformID.Linux | PlatformID.OSX)]
+        public void NegotiateStream_StreamToStream_KerberosAuthDefaultCredentials_Success()


Let us add a DefaultCreds_failure test case where TGT does not exist before calling AuthenticateAsClientAsync

kapilash · 2016-02-17T07:19:19Z

With the fixture setup done here, will remove the sample code from #6028

Thanks @Priya91 This fixture was written based on your sample code.

Priya91 · 2016-02-18T00:52:37Z

@dotnet-bot Test Outerloop Ubuntu

Initiating Outerloop run to test these changes with the merged changes in #6028

Priya91 · 2016-02-18T19:49:27Z

The netci.groovy changes have been pushed to master, and should be used for outerloop ubuntu14.04 runs. Triggering an outerloop run to verify.

Priya91 · 2016-02-18T19:49:47Z

@dotnet-bot test outerloop Ubuntu14.04

Priya91 · 2016-02-18T21:50:07Z

The machine setup works, as the Outerloop Process tests that require admin credentials pass in the run. However, while running setup-kdc.sh there is a permission denied error, as the script is not having execute permission.

vijaykota · 2016-02-19T05:31:54Z

+                Assert.False(client.IsAuthenticated, "client is not authenticated before AuthenticateAsClient call");
+
+                Task[] auth = new Task[2];
+                string user = string.Format("{0}@{1}", TestConfiguration.KerberosUser, TestConfiguration.Realm);


Nit: unused var

vijaykota · 2016-02-19T09:44:21Z

@kapilash , few more changes (uninstall etc.) will be needed since the script has been updated - see #6158

kapilash · 2016-02-23T15:21:35Z

I am removing the (do not merge) tag since all the prereqs have landed into the dev branch.

vijaykota · 2016-02-24T06:26:23Z

LGTM. @stephentoub , please see if the latest commit looks good. This will help unblock @shrutigarg who is working on adding NTLM tests

stephentoub · 2016-02-24T13:59:38Z

+        private static int RunSetupScript(string args = null)
+        {
+            ProcessStartInfo startInfo = new ProcessStartInfo();
+            startInfo.UseShellExecute = true;


Nit: Why true? It looks like the command being launched itself invokes bash.

stephentoub · 2016-02-24T14:09:08Z

A few more nits, but otherwise looks good. You can merge once the few things are addressed. Thanks!

* Tests install kdc on the local machine via kdc-setup.sh (The script will be run as admin)

kapilash · 2016-02-24T15:09:15Z

Thanks @stephentoub - I fixed them.
I am also squashing the commits. Some how the CI machine did not pick up the earlier commit.

Priya91 · 2016-02-25T01:25:43Z

@dotnet-bot Test Outerloop Ubuntu14.04

kapilash · 2016-02-25T03:54:53Z

Outer loop tests failed with :

 java.io.IOException: remote file operation failed: /mnt/j/workspace/dotnet_corefx/outerloop_ubuntu14.04_debug_prtest at hudson.remoting.Channel@3f4a6cea:Azure0224034215: hudson.util.IOException2: There are some problems during the conversion into JUnit reports:

System.Net.Security.Tests did succeed

 19:19:11   
 19:19:11   === TEST EXECUTION SUMMARY ===
  19:19:11      System.Net.Security.Tests  Total: 10, Errors: 0, Failed: 0, Skipped: 0, Time: 1.087s

vijaykota · 2016-02-25T05:44:35Z

System.Net.Security.Tests did succeed

Thanks for the combined effort, @Priya91 , @rahulkotecha and @kapilash

@Priya91 can you extend the changes for Ubuntu to other outerloop OSs?

vijaykota · 2016-02-25T07:02:35Z

@dotnet-bot, Test Innerloop CentOS7.1

kapilash · 2016-02-25T07:33:51Z

Failures in CentOS are due to

System.IO.FileNotFoundException : Could not load file or assembly 'System.Diagnostics.TraceSource, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

kapilash · 2016-02-25T08:48:36Z

I am merging this to the dev/negotiate branch to unblock ntlm tests. The tests seem to have run successfully and the failures are all unrelated.
Please give me shout, if it is a problem. I'll revert the commit.

NegotiateStream Tests on Unix

dnfclas added the cla-already-signed label Feb 16, 2016

dotnet-bot added the 2 - In Progress label Feb 16, 2016

stephentoub reviewed Feb 16, 2016
View reviewed changes

stephentoub reviewed Feb 17, 2016
View reviewed changes

vijaykota added the Needs extra testing before merge label Feb 17, 2016

vijaykota reviewed Feb 17, 2016
View reviewed changes

kapilash force-pushed the tests/negotiate branch from 901b652 to 83cb0e3 Compare February 17, 2016 08:15

vijaykota mentioned this pull request Feb 18, 2016

KDC setup for Linux #6158

Merged

Priya91 mentioned this pull request Feb 18, 2016

Make setup-kdc.sh executable. #6222

Merged

vijaykota reviewed Feb 19, 2016
View reviewed changes

vijaykota added * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) and removed Needs extra testing before merge * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) labels Feb 19, 2016

kapilash force-pushed the tests/negotiate branch 2 times, most recently from c26cd43 to f079a7c Compare February 23, 2016 15:20

kapilash changed the title ~~NegotiateStream Tests on Unix (do not merge)~~ NegotiateStream Tests on Unix Feb 23, 2016

stephentoub reviewed Feb 24, 2016
View reviewed changes

NegotiateStream Tests on Linux

3e3e68f

* Tests install kdc on the local machine via kdc-setup.sh (The script will be run as admin)

kapilash force-pushed the tests/negotiate branch from 40e2c8f to 3e3e68f Compare February 24, 2016 15:07

kapilash added a commit that referenced this pull request Feb 25, 2016

Merge pull request #6139 from kapilash/tests/negotiate

b7634b6

NegotiateStream Tests on Unix

kapilash merged commit b7634b6 into dotnet:dev/negotiatestream Feb 25, 2016

dotnet-bot removed the 2 - In Progress label Feb 25, 2016

karelz added this to the 1.0.0-rtm milestone Jan 21, 2017

karelz added the area-System.Net label Jan 21, 2017



		GssBuffer inputToken {.length = UnsignedCast(inputLength), .value = inputBytes};
		GssBuffer gssBuffer { .length = 0, .value = nullptr };

Conversation

kapilash commented Feb 16, 2016

Uh oh!

stephentoub Feb 16, 2016

Choose a reason for hiding this comment

Uh oh!

Priya91 commented Feb 16, 2016

Uh oh!

stephentoub Feb 17, 2016

Choose a reason for hiding this comment

Uh oh!

stephentoub commented Feb 17, 2016

Uh oh!

vijaykota commented Feb 17, 2016

Uh oh!

vijaykota Feb 17, 2016

Choose a reason for hiding this comment

Uh oh!

kapilash commented Feb 17, 2016

Uh oh!

Priya91 commented Feb 18, 2016

Uh oh!

Priya91 commented Feb 18, 2016

Uh oh!

Priya91 commented Feb 18, 2016

Uh oh!

Priya91 commented Feb 18, 2016

Uh oh!

vijaykota Feb 19, 2016

Choose a reason for hiding this comment

Uh oh!

vijaykota commented Feb 19, 2016

Uh oh!

kapilash commented Feb 23, 2016

Uh oh!

vijaykota commented Feb 24, 2016

Uh oh!

stephentoub Feb 24, 2016

Choose a reason for hiding this comment

Uh oh!

stephentoub commented Feb 24, 2016

Uh oh!

kapilash commented Feb 24, 2016

Uh oh!

Priya91 commented Feb 25, 2016

Uh oh!

kapilash commented Feb 25, 2016

Uh oh!

vijaykota commented Feb 25, 2016

Uh oh!

vijaykota commented Feb 25, 2016

Uh oh!

kapilash commented Feb 25, 2016

Uh oh!

kapilash commented Feb 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants