This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add Http redirect tests#7760
Merged
stephentoub merged 1 commit intodotnet:masterfrom Apr 15, 2016
davidsh:redirect_tests
Merged
Add Http redirect tests#7760stephentoub merged 1 commit intodotnet:masterfrom davidsh:redirect_tests
stephentoub merged 1 commit intodotnet:masterfrom
davidsh:redirect_tests
Conversation
Now that the Azure test endpoint has been updated, we can add more redirect tests that use different redirect status codes. It isn't necessary to modify every existing test to use different codes. But I modified the important ones especially those using credentials. Fixes #7505
Contributor
Author
|
cc: @stephentoub |
Member
|
LGTM |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Add Http redirect tests Commit migrated from dotnet/corefx@9899b0f
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
PR dotnet/corefx#7760 broke the compilation of these tests but wasn't discovered in CI since WinHttpHandler tests weren't building properly. This PR will fix the compiler error while PR dotnet/corefx#7747 will make sure that these tests get built/run again in CI. Commit migrated from dotnet/corefx@948e7fd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the Azure test endpoint has been updated, we can add more redirect tests that use different redirect status codes.
It isn't necessary to modify every existing test to use different codes. But I modified the important ones especially those using credentials.
Fixes #7505