This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix build problem in WinHttpHandler tests#7777
Merged
davidsh merged 1 commit intodotnet:masterfrom Apr 15, 2016
davidsh:fix_build
Merged
Fix build problem in WinHttpHandler tests#7777davidsh merged 1 commit intodotnet:masterfrom davidsh:fix_build
davidsh merged 1 commit intodotnet:masterfrom
davidsh:fix_build
Conversation
Contributor
Author
Member
|
LGTM FYI, I would not be surprised if some of the tests fail on Unix; in particular, I expect ones related to a 300-status code redirect may fail to handle credentials correctly. If they do, just mark 'em as ActiveIssue and I'll fix. |
Contributor
Author
WinHttpHandler tests are not supposed to run in *Nix. I thought we suppressed that in the *.CSPROJ: |
Member
|
Oh! Sorry, I missed that this was just affecting WinHttpHandler. Nevermind. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix build problem in WinHttpHandler tests Commit migrated from dotnet/corefx@ccf3cbe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #7760 broke the compilation of these tests but wasn't discovered in CI since WinHttpHandler
tests weren't building properly. This PR will fix the compiler error while PR #7747 will make
sure that these tests get built/run again in CI.