This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Add support for non-GC static fields#17
Merged
Merged
Conversation
This change includes: 1. Static field layout computation (general purpose enough to cover GC statics and thread statics) 2. Associated codegen support to generate helpers and calls to helpers (non-GC, non-thread, non-RVA fields only, with no support for class constructors and associated semantics) 3. Emission of the non-GC static section into the assembly file
Member
Author
|
@jkotas Can you have a look please? @davidwrighton Can you please review type system changes? You also indicated dislike of the FieldMason type name - now is your chance to suggest a better name. I picked "mason" because a brick mason in the real world lays out bricks and a field mason, well, lays out fields. |
Member
There was a problem hiding this comment.
This should use TypeDesc.UnderlyingType
Member
There was a problem hiding this comment.
It may not be actually needed. See my other feedback. Delete it?
Member
|
LGTM otherwise |
Member
FieldLayoutAlgorithm? |
MichalStrehovsky
added a commit
that referenced
this pull request
Oct 2, 2015
Add support for non-GC static fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change includes:
statics and thread statics)
(non-GC, non-thread, non-RVA fields only, with no support for class
constructors and associated semantics)