This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Unify caching pattern between EcmaMethod and EcmaField#19
Merged
Conversation
Member
|
LGTM |
I have looked a bit at the right pattern to use for caching of metadata {Field|Method}DefinitionHandle vs. {Field|Method}Definition: The conversion from XXXDefinitionHandle to XXXDefinition is cheap. It is sufficient to cache just XXXDefinitionHandle, and recompute XXXDefinition each time - updated EcmaMethod implementation to match.
Also, I have removed MethodDefinition and FieldDefiniton helper properties from EcmaMethod and EcmaField because of they were confusing (and JIT have not generated a particularly good code for them).
jkotas
added a commit
that referenced
this pull request
Oct 2, 2015
Unify caching pattern between EcmaMethod and EcmaField
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have looked a bit at the right pattern to use for caching of metadata {Field|Method}DefinitionHandle vs. {Field|Method}Definition: The conversion from XXXDefinitionHandle to XXXDefinition is cheap. It is sufficient to cache just XXXDefinitionHandle, and recompute XXXDefinition each time - updated EcmaMethod implementation to match.
Also, I have removed MethodDefinition and FieldDefiniton helper properties from EcmaMethod and EcmaField because of they were confusing (and JIT have not generated a particularly good code for them).