This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Make GC and GCSample compile and run on Linux#5
Merged
Conversation
Member
There was a problem hiding this comment.
I would delete these commented out lines.
Contributor
Author
There was a problem hiding this comment.
These lines are not commented out - they are comments explaining the meaning and other possible variations of the compatibility/extension option. That's exactly what we have in coreclr. Besides, they can be useful for the MRT port so I think it is good to have them here.
Member
There was a problem hiding this comment.
I just meant -fms-compatibility and fms-extensions . These two start with # and thus they are commented out.
We have played with them in CoreCLR, but decided that they are not useful - commented them out, but have not deleted them yet.
Member
|
LGTM, could you please squash the two commits before merging? |
:# Please enter the commit message for your changes. Lines starting
sergiy-k
added a commit
that referenced
this pull request
Sep 18, 2015
Make GC and GCSample compile and run on Linux
This was referenced Jan 27, 2016
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required bringing some of the CMake configuration settings from the coreclr repo.