This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Wasm: fix unsigned extend to uint64 and add test#7891
Merged
jkotas merged 2 commits intodotnet:masterfrom Dec 12, 2019
Merged
Conversation
This was referenced Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This widening cast was failing, particular causing a problem in
corert/src/System.Private.CoreLib/shared/System/Number.DiyFp.cs
Lines 77 to 103 in 8d81b96
Added a test that failed previously and zext instead of sext for unsigned widening. There is a parameter that I thought to use, but it is passed false here: https://github.com/dotnet/corert/blob/master/src/Common/src/TypeSystem/IL/ILImporter.cs#L574-L578. Maybe that is wrong?
Also I updated emscripten, this wasn't necessary to fix this, but I got sidetracked with a build error and upgraded. Its not a bad idea anyway as they changed the build tooling to allow for either the fastcomp or llvm backend and we will need to upgrade at some point. If you just
git pullemscripten you will hit a problem with the current scripts due to these changes. Changed a bit of documentation to fit today's reality.