This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Wasm: fix for boxing a float32 into Single#7894
Merged
jkotas merged 9 commits intodotnet:masterfrom Dec 24, 2019
Merged
Conversation
yowl
changed the title
jkotas
reviewed
Dec 22, 2019
| MethodDesc helper = _compilation.TypeSystemContext.GetHelperEntryPoint("LdTokenHelpers", "GetRuntimeTypeHandle"); | ||
| AddMethodReference(helper); | ||
| HandleCall(helper, helper.Signature); | ||
| if (ConstructedEETypeNode.CreationAllowed(typeDesc)) |
Member
There was a problem hiding this comment.
This should rather be MaximallyConstructableType that does the right thing for both CreationAllowed and !CreationAllowed cases.
Contributor
Author
There was a problem hiding this comment.
Thanks, have changed to be unconditionally MaximallyConstructableType and removed couple of unused variables.
jkotas
reviewed
Dec 23, 2019
| @@ -3109,16 +3109,15 @@ private void ImportLdToken(int token) | |||
| { | |||
| var ldtokenValue = _methodIL.GetObject(token); | |||
| WellKnownType ldtokenKind; | |||
Member
There was a problem hiding this comment.
Delete this variable completely?
Member
|
Could you please fix the conflict? |
# Conflicts: # tests/src/Simple/HelloWasm/Program.cs
Contributor
Author
|
Missed that. Done now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test and the fix for :
Which was failing due to using a float64 and not trunking the float64 into a float32 before calling RhBox. Also added code to ensure that type used in the reflection has its type symbol add to the dependencies to prevent missing metadata exception. WIP as contains changes from #7891 so will wait for that before releasing.