Skip to content

Use ICLRRuntimeHost4#10466

Merged
rpetrusha merged 2 commits into
dotnet:masterfrom
nxtn:master
Feb 20, 2019
Merged

Use ICLRRuntimeHost4#10466
rpetrusha merged 2 commits into
dotnet:masterfrom
nxtn:master

Conversation

@nxtn
Copy link
Copy Markdown
Contributor

@nxtn nxtn commented Feb 14, 2019

Related to dotnet/samples#635

Uses space alignment to prevent the code block from being rendered differently.

/cc @mjrousos

@nxtn nxtn requested a review from mairaw as a code owner February 14, 2019 05:28
Copy link
Copy Markdown
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NextTurn, for making this update. I've left two suggestions for changes; we've been trying to replace gerunds ("Creating...") with imperatives ("Create...") in titles and headers.

Comment thread docs/core/tutorials/netcore-hosting.md Outdated
Comment thread docs/core/tutorials/netcore-hosting.md Outdated
@nxtn
Copy link
Copy Markdown
Contributor Author

nxtn commented Feb 20, 2019

@rpetrusha Is this style guide contained in microsoft-style-guide repo? I can't find it there.

@rpetrusha
Copy link
Copy Markdown
Contributor

It's in the template, @NextTurn.

@rpetrusha
Copy link
Copy Markdown
Contributor

Thanks, @NextTurn, both for the PR and the additional changes. I'll merge now.

@rpetrusha rpetrusha merged commit 77c32ec into dotnet:master Feb 20, 2019
@nxtn
Copy link
Copy Markdown
Contributor Author

nxtn commented Feb 21, 2019

Is it the one in the File name section? Does the rule below about small words also apply to titles?

* Use action verbs that are specific, such as develop, buy, build, troubleshoot. No -ing words.
* No small words - don't include a, and, the, in, or, etc.

@rpetrusha
Copy link
Copy Markdown
Contributor

I think it depends on the title and whether it makes sense without the small word, @NextTurn.

@nxtn nxtn mentioned this pull request Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants