Update .NET Core hosting samples#635
Merged
Merged
Conversation
mjrousos
reviewed
Feb 11, 2019
Member
mjrousos
left a comment
mjrousos
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up. I'm not sure the coreclr_shutdown change is necessary, though. Both APIs are fine to use and we don't take advantage of _2's extra parameter in the sample.
Contributor
Author
|
It depends on the author @mjrousos. |
Member
|
Sorry for the delay here. Changes look good! |
mjrousos
approved these changes
Feb 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to dotnet/coreclr#10842 and dotnet/coreclr#10967.
Changes
ICLRRuntimeHost2toICLRRuntimeHost4.