Skip to content

Update default reviewers#15355

Merged
mairaw merged 7 commits intodotnet:masterfrom
mairaw:owners
Oct 23, 2019
Merged

Update default reviewers#15355
mairaw merged 7 commits intodotnet:masterfrom
mairaw:owners

Conversation

@mairaw
Copy link
Copy Markdown
Contributor

@mairaw mairaw commented Oct 22, 2019

Part I of our retirement gift to @rpetrusha 🎁

This only sets the default reviewers on the codeowners file.

@mairaw mairaw added this to the October 2019 milestone Oct 22, 2019
@mairaw mairaw requested a review from a team October 22, 2019 19:51
@mairaw mairaw self-assigned this Oct 22, 2019
@rpetrusha
Copy link
Copy Markdown
Contributor

Thank you, @mairaw!

@mairaw
Copy link
Copy Markdown
Contributor Author

mairaw commented Oct 22, 2019

What are you doing here? 😄 Go relax!

Copy link
Copy Markdown
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rpetrusha
Copy link
Copy Markdown
Contributor

I just happened to be checking email.

Copy link
Copy Markdown
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

I had one question if an area is related. I'll defer to @gewarren if she wants it changed.

Comment thread .github/CODEOWNERS Outdated
# Assembly
/docs/standard/assembly/** @gewarren
# Asynchronous Programming Patterns
/docs/standard/asynchronous-programming-patterns/** @gewarren
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got responsibility for async in C# (along with threading). This is related. Also, happy to work with @gewarren to make sure these areas are seamless.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense @BillWagner. We should ensure that no one is overwhelmed by the number of PRs.

Comment thread .github/CODEOWNERS Outdated
Copy link
Copy Markdown
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a handful of folders missing from under docs/framework, but is that just because they'll fall under the umbrella of the parent folder code owner?

Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS
Comment thread .github/CODEOWNERS
Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS
Comment thread .github/CODEOWNERS
Comment thread .github/CODEOWNERS Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants