Skip to content

Update structure marshaling guidance for .NET Core 3.0#15616

Merged
mairaw merged 2 commits intodotnet:masterfrom
nxtn:patch-1
Nov 1, 2019
Merged

Update structure marshaling guidance for .NET Core 3.0#15616
mairaw merged 2 commits intodotnet:masterfrom
nxtn:patch-1

Conversation

@nxtn
Copy link
Copy Markdown
Contributor

@nxtn nxtn commented Nov 1, 2019

Contributes to #11396

Continued from #12101

dotnet/coreclr#22041 fixed marshaling explicit-layout structures on non-Windows platforms.

/cc @jkoritzinsky

@nxtn
Copy link
Copy Markdown
Contributor Author

nxtn commented Nov 1, 2019

@mairaw

@jkoritzinsky is not identified as the code owner. #15355

@Youssef1313
Copy link
Copy Markdown
Member

@mairaw

@jkoritzinsky is not identified as the code owner. #15355

https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

The people you choose as code owners must have write permissions for the repository.

I'm not sure if he has write permissions in dotnet/docs repo, but if he doesn't have write permissions then that is the problem.

@nxtn
Copy link
Copy Markdown
Contributor Author

nxtn commented Nov 1, 2019

I'm not sure if he has write permissions

The approval marks of those who have write access are green.

@Youssef1313
Copy link
Copy Markdown
Member

I'm not sure if he has write permissions

The approval marks of those who have write access are green.

Well, then this is the problem.

@mairaw
Copy link
Copy Markdown
Contributor

mairaw commented Nov 1, 2019

We're revisiting all the assignments, code owners, perms, etc. I'm still in the process of doing this after Ron left but I can review and approve this in the meantime given that @jkoritzinsky already approved this.

Copy link
Copy Markdown
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request before we merge

Comment thread docs/standard/native-interop/customize-struct-marshaling.md Outdated
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Copy link
Copy Markdown
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the additional change.

@mairaw mairaw merged commit 03e3828 into dotnet:master Nov 1, 2019
@nxtn nxtn deleted the patch-1 branch November 1, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants