Updates re MD5/SHA1 usage second batch #2953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thraka
added
the
vendor-project
Thraka
approved these changes
Aug 20, 2019
Contributor
Thraka
left a comment
Thraka
left a comment
There was a problem hiding this comment.
Looks great! One item for you to edit.
| <summary>Gets a new <see cref="T:System.Security.Cryptography.CngAlgorithm" /> object that specifies the Message Digest 5 (MD5) hash algorithm.</summary> | ||
| <value>An object that specifies the MD5 algorithm.</value> | ||
| <remarks>To be added.</remarks> | ||
| <remarks>Due to collision problems with MD5, Microsoft recommends SHA256.</remarks> |
Contributor
There was a problem hiding this comment.
I think this one would be the "model" phrase since according to the summary the value is always an MD5 value.
mairaw
added a commit
that referenced
this pull request
Aug 21, 2019
* Updates re MD5/SHA1 usage second batch (#2953) * Add SHA1 recommendations. * Fix typo. * Fix typo again. * Fix per review. * Update ReflectionOnly methods for .NET Core (#3056) Add System.PlatformNotSupportedException doc. * CI Update - Update .NET Standard 2.1 Preview (#3055) * CI Update * readd dropped content/apis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add recommendation to avoid MD5/SHA1.
Fixes 1572540
Contributes to dotnet/docs#13441
@Thraka
Hi Andy - this is the other PR for this work item. I've tried to take into account comments from the last one, but these are still a file type we don't deal with much, so your input is important.
After this one, I'll resolve the user story back to you.