CI Update - Update .NET Standard 2.1 Preview #3055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
requested review from
KathleenDollard,
karelz,
scottaddie and
stevestein
as code owners
rpetrusha
approved these changes
Aug 20, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I thought I'd approve just in case, @mairaw, but there are a number of troubling things in this PR. Some (evidently) 1.1-only APIs have been dropped, as have some .NET Standard 2.1 preview items. I think that my comments identify most of the trouble areas.
mairaw
added
the
🏁 Release: .NET Core 3.0
Contributor
Author
|
Thank you for your thorough review @rpetrusha. A lot of the issues you've captured mostly fell into two buckets:
|
mairaw
added a commit
that referenced
this pull request
Aug 21, 2019
* Updates re MD5/SHA1 usage second batch (#2953) * Add SHA1 recommendations. * Fix typo. * Fix typo again. * Fix per review. * Update ReflectionOnly methods for .NET Core (#3056) Add System.PlatformNotSupportedException doc. * CI Update - Update .NET Standard 2.1 Preview (#3055) * CI Update * readd dropped content/apis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.