Remove refs to Windows 9x#5453
Merged
gewarren merged 7 commits intodotnet:mainfrom Mar 24, 2021
Merged
Conversation
gewarren
requested review from
a team,
333fred,
AaronRobinsonMSFT,
Anipik,
GrabYourPitchforks,
HongGit,
RussKie,
ViktorHofer,
adamsitnik,
bartonjs,
carlossanlop,
cston,
jkoritzinsky,
jozkee,
kouvel,
maryamariyan,
merriemcgaw,
pgovind,
safern,
tannergooding and
tarekgh
as code owners
ghost
added
the
gewarren
commented
Mar 22, 2021
cston
reviewed
Mar 22, 2021
gewarren
commented
Mar 22, 2021
cston
reviewed
Mar 22, 2021
gewarren
commented
Mar 22, 2021
This comment has been minimized.
This comment has been minimized.
bartonjs
approved these changes
Mar 23, 2021
cston
approved these changes
Mar 23, 2021
GrabYourPitchforks
approved these changes
Mar 23, 2021
This comment has been minimized.
This comment has been minimized.
RussKie
reviewed
Mar 23, 2021
Contributor
RussKie
left a comment
RussKie
left a comment
There was a problem hiding this comment.
Each of the API in xml/System.Windows.Forms/SystemInformation.xml need to be cross checked against Win32 definitions (most, if not all, in WinUser.h). Some of the API are supported as far back as W2000 or XP.
At the moment this looks confusing - we're removing some notes completely (which note support from W2000/XP onwards), yet we're removing some other comments stating the same.
BillWagner
approved these changes
Mar 23, 2021
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM @gewarren
You can 
when ready.
tannergooding
approved these changes
Mar 23, 2021
| > This property is supported only on Windows NT 4.0 SP4 or later, Windows 98, Windows Millennium Edition, Windows 2000, Windows XP, and the Windows Server 2003 family. | ||
|
|
||
|
|
||
| > This property is supported only on Windows NT 4.0 SP4 or later, Windows 2000, Windows XP, and the Windows Server 2003 family. |
Contributor
There was a problem hiding this comment.
Do we still support any of these? Or should the whole sentence be removed?
Contributor
There was a problem hiding this comment.
This and similar notes must be removed.
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Thanks for the change, @gewarren! There are some suggestions for you to consider.
cc @danmoseley who raised the question of having old OS mentions removed from Docs.
danmoseley
reviewed
Mar 23, 2021
danmoseley
reviewed
Mar 23, 2021
danmoseley
reviewed
Mar 23, 2021
danmoseley
approved these changes
Mar 23, 2021
carlossanlop
approved these changes
Mar 23, 2021
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2053