Skip to content

Add OptimizeContext MSBuild target that runs on build#33049

Merged
AndriySvyryd merged 1 commit intomainfrom
Issue24894
Feb 29, 2024
Merged

Add OptimizeContext MSBuild target that runs on build#33049
AndriySvyryd merged 1 commit intomainfrom
Issue24894

Conversation

@AndriySvyryd
Copy link
Copy Markdown
Member

@AndriySvyryd AndriySvyryd commented Feb 10, 2024

Tests tracked by #33136

Even though the compiled model is added to the project, it's not yet discovered, this is tracked by #24893

Fixes #24894

Copy link
Copy Markdown
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndriySvyryd is the idea here to generate the compiled model on every build (during the inner loop), as opposed to on publish? Assuming that we don't have the ability to know when something has changed that requires a model rebuild, is this something we want to do, given that it will make the build much slower?

@AndriySvyryd
Copy link
Copy Markdown
Member Author

@AndriySvyryd is the idea here to generate the compiled model on every build (during the inner loop), as opposed to on publish?

The idea here is to have a task to generate the compiled model when we decide it should be generated.

given that it will make the build much slower?

We need to measure it first

@roji
Copy link
Copy Markdown
Member

roji commented Feb 12, 2024

The idea here is to have a task to generate the compiled model when we decide it should be generated.

OK, sure thing.

@AndriySvyryd AndriySvyryd changed the title Add OptimizeContext MSBuild target Add OptimizeContext MSBuild target that runs on build Feb 22, 2024
@AndriySvyryd AndriySvyryd marked this pull request as ready for review February 22, 2024 02:28
@AndriySvyryd AndriySvyryd requested a review from a team February 22, 2024 02:28
Copy link
Copy Markdown
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits

@AndriySvyryd AndriySvyryd merged commit 52f37b3 into main Feb 29, 2024
@AndriySvyryd AndriySvyryd deleted the Issue24894 branch February 29, 2024 22:51
@cincuranet
Copy link
Copy Markdown
Contributor

@JanKrivanek PTAL, thanks.

Copy link
Copy Markdown
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cincuranet - no strong concerns from msbuild point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate the compiled model during build

5 participants