Refactor OperationTaskBase to derive from ToolTask#33367
Merged
AndriySvyryd merged 1 commit intomainfrom Mar 30, 2024
Merged
Conversation
JanKrivanek
approved these changes
Mar 21, 2024
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Based on a quick look - looks OK from MSBuild point of view
Member
Author
|
@JanKrivanek Thanks! |
AndriySvyryd
force-pushed
the
RefactorTasks
branch
from
cf3729c to
0710f43
Compare
ajcvickers
approved these changes
Mar 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
.gsuffix to the generated filesAnd other PR comments from #33049