Skip to content

Support hierarchical partition keys in Cosmos provider#33536

Merged
ajcvickers merged 2 commits intomainfrom
240404_PartyKeys
May 2, 2024
Merged

Support hierarchical partition keys in Cosmos provider#33536
ajcvickers merged 2 commits intomainfrom
240404_PartyKeys

Conversation

@ajcvickers
Copy link
Copy Markdown
Contributor

Fixes #28186
Fixes #28265
Fixes #33535

Also:

  • Allow non-string partition key values
  • Warn if no partition key has been defined
  • Use a value converter if needed for values passed to WithPartitionKey (This is probably a bug, but should be docced as a breaking change anyway.)

@ajcvickers ajcvickers requested a review from a team April 14, 2024 19:14
Comment thread src/EFCore.Cosmos/Infrastructure/Internal/CosmosModelValidator.cs
Comment thread src/EFCore.Cosmos/Infrastructure/Internal/CosmosModelValidator.cs Outdated
Comment thread src/EFCore.Cosmos/Infrastructure/Internal/CosmosModelValidator.cs
Comment thread src/EFCore.Cosmos/Metadata/Conventions/StoreKeyConvention.cs Outdated
Comment thread src/EFCore.Cosmos/Metadata/Conventions/StoreKeyConvention.cs Outdated
Comment thread src/EFCore.Cosmos/Metadata/Conventions/StoreKeyConvention.cs
Comment thread src/EFCore.Cosmos/Extensions/Internal/PartitionKeyBuilderExtensions.cs Outdated
Copy link
Copy Markdown
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⬆️

ajcvickers added 2 commits May 1, 2024 20:23
Fixes #28186
Fixes #28265
Fixes #33535

Also:
- Allow non-string partition key values
- Warn if no partition key has been defined
- Use a value converter if needed for values passed to WithPartitionKey (This is probably a bug, but should be docced as a breaking change anyway.)

Updated based on review feedback
@ajcvickers ajcvickers merged commit a970d4f into main May 2, 2024
@ajcvickers ajcvickers deleted the 240404_PartyKeys branch May 2, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants