Pack of minor Cosmos changes#34143
Merged
roji merged 1 commit intodotnet:mainfrom Jul 4, 2024
Merged
Conversation
AndriySvyryd
reviewed
Jul 3, 2024
| return null; | ||
| } | ||
|
|
||
| // TODO: ElementAt on top level |
Member
Author
There was a problem hiding this comment.
Yeah, I have a note on it in my list for now... Will open an issue if I don't get around to it soon.
AndriySvyryd
approved these changes
Jul 3, 2024
* Refactor common point for implementation subquery pushdown, and improve error reporting when that happens. * Move pushdown detection logic out of SelectExpression * Detect ToPageAsync in subqueries and throw detailed message * Make SelectExpression sealed * Some relational syntax cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is based on top of #34074, review last commit only