Cosmos: Stop generating discriminator clause when not needed #34145
Merged
roji merged 2 commits intodotnet:mainfrom Jul 4, 2024
Merged
Cosmos: Stop generating discriminator clause when not needed #34145roji merged 2 commits intodotnet:mainfrom
roji merged 2 commits intodotnet:mainfrom
Conversation
roji
commented
Jul 2, 2024
Member
The validation should be pretty simple, just add it |
Member
Author
Which configuration exactly? |
Member
|
Member
Author
|
@AndriySvyryd done |
AndriySvyryd
reviewed
Jul 3, 2024
AndriySvyryd
approved these changes
Jul 3, 2024
Member
Author
|
Thanks for the quick review @AndriySvyryd, will need to merge the base PRs first before I can do this one. |
25f92b9 to
b23a624
Compare
b23a624 to
2e69af4
Compare
2e69af4 to
6d13fff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR is based on top of #34143, review last commit only
@AndriySvyryd this doesn't do validation (which is also part of #20268), we can split that out or if if you feel like it, just push it into this PR?
Closes #20268