Publish Microsoft.Interop.Js and Mono.WebAssembly.Interop#1048
Publish Microsoft.Interop.Js and Mono.WebAssembly.Interop#1048
Conversation
pranavkm
left a comment
pranavkm
left a comment
There was a problem hiding this comment.
Verified the npm tarball gets dumped in packages/${Config)/Shipping.
| <Project DefaultTargets="Build" InitialTargets="_CheckForInvalidConfiguration"> | ||
|
|
||
| <PropertyGroup> | ||
| <PackageVersion Condition=" '$(VersionSuffix)' != '' ">$(VersionPrefix)-$(VersionSuffix)</PackageVersion> |
There was a problem hiding this comment.
Identical to https://github.com/aspnet/AspNetCore/blob/master/eng/targets/Npm.Common.targets except the first 2 lines where the PackageVersion is calculated.
There was a problem hiding this comment.
This is going to use SemVer2 by default. Is that okay for NPM packages?
Btw, here is how Arcade computes this stuff https://github.com/dotnet/arcade/blob/9104c21492e1c6ed98105dd87388bca8f1f1abaa/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.props and https://github.com/dotnet/arcade/blob/c0451509373be4842e44d97fd6b79bf51064e2bc/src/Microsoft.DotNet.Build.Tasks.Packaging/src/build/Packaging.targets
There was a problem hiding this comment.
Does look like semver v2 works with npm, although it does constraint the range specifier: https://github.com/npm/node-semver#prerelease-tags
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
Copied this from SignalR's tslint. Filed dotnet/aspnetcore#7197 to enable this because there's a bunch of warnings that show up when turned on.
natemcmaster
left a comment
natemcmaster
left a comment
There was a problem hiding this comment.
LGTM. You'll need to re-run eng/scripts/GenerateProjectList.ps1 since you're removing a .csproj file.
…ensions#1048) * Publish Microsoft.Interop.Js and Mono.WebAssembly.Interop \n\nCommit migrated from dotnet/extensions@bc2e715
…ensions#1048) * Publish Microsoft.Interop.Js and Mono.WebAssembly.Interop \n\nCommit migrated from dotnet/extensions@bc2e715
ghost
locked as resolved and limited conversation to collaborators
2 participants
No description provided.