Conversation
Member
|
Wow, please tell me there's a test/build task that verifies these are up to date? |
Author
|
I'll add it to code check. |
Author
|
@natemcmaster File was removed in #1048. |
|
Looks like we were getting a false-positive test pass on codecheck due to global.json issues
|
natemcmaster
reviewed
Feb 9, 2019
natemcmaster
left a comment
natemcmaster
left a comment
There was a problem hiding this comment.
Looks like a great start. Still reviewing, but I see you're still pushing changes, so i'll pause here for now.
...rgetingPack/Microsoft.Internal.Extensions.Refs/src/Microsoft.Internal.Extensions.Refs.csproj
Outdated
Show resolved
Hide resolved
...rgetingPack/Microsoft.Internal.Extensions.Refs/src/Microsoft.Internal.Extensions.Refs.csproj
Outdated
Show resolved
Hide resolved
natemcmaster
reviewed
Feb 9, 2019
natemcmaster
reviewed
Feb 9, 2019
....Specification.Tests/src/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj
Outdated
Show resolved
Hide resolved
…xtensions.DependencyInjection.Specification.Tests.csproj Co-Authored-By: pakrym <pavel@krymets.com>
Co-Authored-By: pakrym <pavel@krymets.com>
…soft.Internal.Extensions.Refs.csproj Co-Authored-By: pakrym <pavel@krymets.com>
Author
|
@natemcmaster I'm done with changes for today. |
Author
|
🆙📅 |
pakrym
changed the title
natemcmaster
approved these changes
Feb 11, 2019
5 tasks
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
\n\nCommit migrated from dotnet/extensions@8ad1395
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
\n\nCommit migrated from dotnet/extensions@8ad1395
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
\n\nCommit migrated from dotnet/extensions@8ad1395
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a way to generate reference assembly projects
TODO: