Remove Serilog dependency in extensions #3040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
|
13 tasks
Tratcher
approved these changes
Mar 4, 2020
dougbu
approved these changes
Mar 6, 2020
Author
|
@maryamariyan Note that I had to remove a few more things in Logging.Testing. So the changes in dotnet/runtime will need to be updated when you get to it. |
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
* Remove Serilog dependency in extensions * Add xunit logging for shutdown tests * Need to remove dependency on AspNetCore.Testing and remove DumpCollector Commit migrated from dotnet/extensions@540b4e8
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
* Remove Serilog dependency in extensions * Add xunit logging for shutdown tests * Need to remove dependency on AspNetCore.Testing and remove DumpCollector Commit migrated from dotnet/extensions@540b4e8
This was referenced Mar 19, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
* Remove Serilog dependency in extensions * Add xunit logging for shutdown tests * Need to remove dependency on AspNetCore.Testing and remove DumpCollector Commit migrated from dotnet/extensions@540b4e8
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
* Remove Serilog dependency in extensions * Add xunit logging for shutdown tests * Need to remove dependency on AspNetCore.Testing and remove DumpCollector Commit migrated from dotnet/extensions@540b4e8
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
* Remove Serilog dependency in extensions * Add xunit logging for shutdown tests * Need to remove dependency on AspNetCore.Testing and remove DumpCollector\n\nCommit migrated from dotnet/extensions@540b4e8
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maryamariyan Here's the changes that will remove the serilog dependencies in extensions. I don't know how you'd like to incorporate these changes into your work. Do you want to cherry-pick these changes on your branch? Or merge this PR then merge the commit over to your branch? Or some other way?
FYI, the first commit only removes the dependencies. The second substitutes the file logging we had with XUnit logging. I'm not sure what kind of logging you would prefer in dotnet/runtime so I kept the commits separate. Feel free to use one or both commits.
BTW @anurse I'll work on a PR in aspnetcore to migrate the removed files in this PR.