Resx files are not working for fsharp project

[nguerrera]

From @Lanayx on February 28, 2018 15:1

Steps to reproduce

1. Create empty F# console project (.NET Core)
2. Add type Test = Test of string
3. Add Resources folder
4. Add Resource Test.en.resx to Resources folder
5. Build project

Expected behavior

VS build works
dotnet build works

Actual behavior

VS build works
dotnet build doesn't work.
resources.cs file with fsharp content is created and CS compiler errors are shown

Environment data

.NET Command Line Tools (2.1.4)

Product Information:
Version: 2.1.4
Commit SHA-1 hash: 5e8add2190

Runtime Environment:
OS Name: Windows
OS Version: 10.0.16299
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\2.1.4\

Microsoft .NET Core Shared Framework Host

Version : 2.0.5
Build : 17373eb129b3b05aa18ece963f8795d65ef8ea54

Copied from original issue: dotnet/cli#8697

[nguerrera]

From @livarcocc on February 28, 2018 17:49

This is not currently supported in MSBuild core, but is supported in full MSBuild.

I believe this issue is a duplicate of dotnet/msbuild#2272.

[nguerrera]

From @Lanayx on February 28, 2018 19:7

Looks like the issue is only with F#, if I do the same thing in C#, it works fine. The main problem is that MyProject.resources.cs file is generated for both cases and C# compiler is used for both cases, while .fs file and F# compiler should be used for F# project.

[nguerrera]

From @livarcocc on February 28, 2018 19:38

@KevinRansom can you take a look?

@nguerrera just corrected me. We do support resx files. MSBuild just doesn't support non-string assets in it. But that does not look like the issue here.

[nguerrera]

From @Lanayx on February 28, 2018 19:39

Just checked Visual Basic, it has exactly the same issue. Only C# version works fine.

[nguerrera]

From @peterhuene on March 15, 2018 1:16

I see this working in master:

$ mkdir repro && cd repro

$ dotnet new console -lang f#

$ cat <<EOF > Program.fs
open System
open System.Resources

[<EntryPoint>]
let main argv =
    Console.WriteLine(ResourceManager("repro.Strings", System.Reflection.Assembly.GetCallingAssembly()).GetObject("HelloWorld"))
    0
EOF

$ cat <<EOF > Strings.resx
<?xml version="1.0" encoding="utf-8"?>
<root>
  <data name="HelloWorld" xml:space="preserve">
    <value>Hello World!</value>
  </data>
</root>
EOF

$ dotnet run
Hello World!

I don't think the F# SDK currently supports strongly-typed resources (hence the manual use of ResourceManager above).

[nguerrera]

From @Lanayx on March 15, 2018 3:55

It was supported when I created the issue if building from VS.

[nguerrera]

From @livarcocc on March 15, 2018 4:10

@KevinRansom to comment.

[nguerrera]

This is a duplicate of dotnet/sdk#1748

It is now fixed. The fix will be in 2.1.102 which will ship very soon and be delivered with a VS 15.6.x update.

Get Outlook for iOShttps://aka.ms/o0ukef

---

From: Livar notifications@github.com
Sent: Wednesday, March 14, 2018 9:10:36 PM
To: dotnet/cli
Cc: Nick Guerrera; Mention
Subject: Re: [dotnet/cli] Resx files are not working for fsharp project (#8697)

@KevinRansomhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkevinransom&data=04%7C01%7CNick.Guerrera%40microsoft.com%7Ce08f8e9ffa1a4d1d2f9d08d58a2ab597%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636566838397275399%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=ZL%2BNrBGfnQC4BGaeDd35zN8JQI9DMKNwwGXWSplOX3s%3D&reserved=0 to comment.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fcli%2Fissues%2F8697%23issuecomment-373254904&data=04%7C01%7CNick.Guerrera%40microsoft.com%7Ce08f8e9ffa1a4d1d2f9d08d58a2ab597%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636566838397275399%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=QuB6MUrq34L7UDwAFn9%2BH5f8q7Wi81rboPQM1CQEFu0%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAEmzpnvBiWCkcGiuFqvy-5_mQ2ejBO1ks5teem8gaJpZM4SWy6W&data=04%7C01%7CNick.Guerrera%40microsoft.com%7Ce08f8e9ffa1a4d1d2f9d08d58a2ab597%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636566838397275399%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=Vvuey09STXIyes6KFR8aaX%2Bs%2BEbG%2FT4HyZfkNWtWiZ4%3D&reserved=0.

[nguerrera]

From @Lanayx on March 21, 2018 7:12

Tried the latest 15.6.3 update (dotnet version 2.1.102) - the error is different:

Error writing code fragment: System.Exception: Language name must be F#
   at Microsoft.FSharp.Build.WriteCodeFragment.Microsoft-Build-Framework-ITask-Execute()
Build FAILED.

But the result is the same, it still doesn't work... Please reopen the issue.

[nguerrera]

From @livarcocc on March 21, 2018 16:7

@nguerrera can you please take a look and if necessary re-activate the SDK issue?

[nguerrera]

@brettfo It looks like F# is overriding the WriteCodeFragment task to only support F#. I think you either need to give your task another name or support a superset of built-in WriteCodeFragment (C#, VB).

https://github.com/Microsoft/visualfsharp/blob/a44472c8d92652ee16e05a90a40fe0a7f41328c3/src/fsharp/FSharp.Build/Microsoft.FSharp.Targets#L28

We always use csc to generate satellite assemblies regardless of code language. We therefore need to write the satellite assembly attributes in C# syntax.

[brettfo]

I originally tried to add this to MSBuild in dotnet/msbuild#2585 but was told to do it in the F# sources.

Speaking with @KevinRansom we can add a fallback to generate C# from our task when necessary.

[nguerrera]

Honestly, I think dotnet/msbuild#2585 was the best solution given current architectural limiations. @AndyGerlicher can we reconsider that? The task can't just be overridden, it needs to be extended to handle additional cases. There's no real way to do that in msbuild. I don't get why it can hard-code C# and VB but not F#.