Fix issue# 4591 - Resx files are not working for fsharp project #4595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
approved these changes
Mar 21, 2018
Contributor
|
How does this relate to the resx file? |
Contributor
Author
|
@TIHan well ... under the cover the dotnet sdk generates satellite assemblies for the resx, and it uses the C# compiler to compile them. Unfortunately for them, when they try to generate the source code for the attributes they use our build task to do that, and it fails when the language is not set to "F#". This change allows our WriteCodeFragment to generate thos attribute files in C# and VB. Kevin. |
TIHan
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4591
The WriteCodeFragment for F# projects replaces the netsdk version. Now for F# projects that should have been fine, except that the dotnetsdk uses C# for creating sattelitte assemblies.
This fix,
Updates the WriteCodeFragment for F# projects to write C# and VB attributes, when the language is set to F#.
Update tests for the buildtask
Moves Build task unit tests from coreunit tests to compilerunittests.
Ensures that build.bat runs coreclr fsharp unit tests with:
build test-coreclr-fsharp