Go back to an SDK that is actually installed on machines #10076
Conversation
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
@brettfo ,
- Do we still need this to be 3.1.302 or can it be updated?
- What do we need to do about the 3.1.302 we download to .dotnet?
- The last arcade auto-insert tried to set it to: 5.0.0-beta.20451.5 which seems to be what we aought to aim for
Thanks Brett
|
Internal builds will fail as noted in #10051 but I think we just need to get those VMs updated. |
global.json
Outdated
| "dotnet": "3.1.302", | ||
| "dotnet": "3.1.401", | ||
| "vs": { | ||
| "version": "16.4", |
There was a problem hiding this comment.
If you're updating to 3.1.401, then this line has to be updated to 16.7, because 401 depends on that specifically.
You'll also need to run this against the internal signed build. Like @jonsequitur mentioned, we had to back this change off due to the internal VMs lagging, but last week they were updated with 16.7.
There was a problem hiding this comment.
Okay, updated. Will it work now?
|
@KevinRansom we can't take Arcade's 5.0 SDK updates until the tailcall regression makes it through. It's been checked into their 5.0 release branch which means the next release should have the fix. |
|
this passes CI, i assume we can take it in now |
)" This reverts commit 192a5f6.
* Go back to an SDK that is actually installed on machines * Update global.json
…net#10076)" (dotnet#10095) This reverts commit 192a5f6.
4 participants
fixes #10073 and reverts #10051
Note that the internal build in #10051 also failed, so we've simply regressed this repo's contribution story with no benefit.