Update framework refencing #10502
Merged
Update framework refencing #10502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
reviewed
Nov 19, 2020
| let mutable errors = "" | ||
| let mutable cleanUp = true | ||
| let projectDirectory = Path.Combine(Path.GetTempPath(), "CompilerAssert", Path.GetRandomFileName()) | ||
| let pathToTemp = Path.GetFullPath(Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "../../../../Temp")) |
Contributor
Author
There was a problem hiding this comment.
Not at all, I want us to pick up the global.json in the repo. %temp% is in the user directory, and so is nowhere near the repo
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" /> | ||
| </Project> | ||
| """ |
Member
There was a problem hiding this comment.
Are you trying to prevent all directory crawling? If so, this file should just be an empty <Project /> element and a similarly emtpy Directory.Build.targets should be present, too.
brettfo
approved these changes
Nov 19, 2020
vzarytovskii
approved these changes
Nov 19, 2020
Member
vzarytovskii
left a comment
vzarytovskii
left a comment
There was a problem hiding this comment.
That's actually good. Easier to clean up and find generated stuff if you need to debug. Thanks, Kevin.
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Dec 3, 2020
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Dec 3, 2020
KevinRansom
added a commit
that referenced
this pull request
Dec 4, 2020
* add check for system assemblies completion * add check for system assemblies completion * add check for system assemblies completion * merge issues * add FCS release definition links * Fix FSC nuget package dependencies. Use FSharp.Org tool Icon as package icon. (#10588) * src/fsharp/DotNetFrameworkDependencies.fs * System.Config * version * Update bframework refencing (#10502) * Fix release notes link * temp (#10506) Co-authored-by: Don Syme <donsyme@fastmail.com> Co-authored-by: Brett V. Forsgren <brettfo@microsoft.com>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* add check for system assemblies completion * add check for system assemblies completion * add check for system assemblies completion * merge issues * add FCS release definition links * Fix FSC nuget package dependencies. Use FSharp.Org tool Icon as package icon. (dotnet#10588) * src/fsharp/DotNetFrameworkDependencies.fs * System.Config * version * Update bframework refencing (dotnet#10502) * Fix release notes link * temp (dotnet#10506) Co-authored-by: Don Syme <donsyme@fastmail.com> Co-authored-by: Brett V. Forsgren <brettfo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies compilerassert setup.