Prepare to ship fcs 38.0.1 #10592
Merged
Prepare to ship fcs 38.0.1 #10592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Dec 3, 2020
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Looks good to me, but should there also be placeholder links in the release-notes.md file that correspond to the version?
Member
|
Poking this, what's the cadence for this release? I wasn't sure if this MR was a signal to expect FCS to be pushed to nuget or what. |
Contributor
Author
|
@baronfel , we are having problems uploading it to nuget. Apparently the system has changed again and now Microsoft needs to be a co-owner of the repo, I believe Phillip is working out the details. Kevin |
Member
|
Thanks for the update, Kevin! |
Contributor
Author
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* add check for system assemblies completion * add check for system assemblies completion * add check for system assemblies completion * merge issues * add FCS release definition links * Fix FSC nuget package dependencies. Use FSharp.Org tool Icon as package icon. (dotnet#10588) * src/fsharp/DotNetFrameworkDependencies.fs * System.Config * version * Update bframework refencing (dotnet#10502) * Fix release notes link * temp (dotnet#10506) Co-authored-by: Don Syme <donsyme@fastmail.com> Co-authored-by: Brett V. Forsgren <brettfo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
38.0.1 is a servicing release of fcs it contains:
Also contains test case fixes to run on the re-imaged vms.
There will be an additional preview release of everything in master branch with the version# 39.0.1-preview-*
/cc @baronfel , @dsyme , @cartermp