Revert the revert of fssrgen

[enricosada]

To use FsSrGen package and remove from lkg the fssrgen.exe and msbuild task

ref #962
old reverted pr #963

[enricosada]

@dotnet-bot test Windows_NT Debug Build please

[KevinRansom]

Where is this define used?

[enricosada]

the generated file from fssrgen contains an #if NETSTANDARD1_5 so the same file can work for both net46 and netstandard1.5 (dnxcore50 too, but now is useless)
NETSTANDARD1_5 it's the default define added for netstandard1.5 framework (like NET46 for .net 4.6)

[KevinRansom]

Does the generated code need to be different?

From: Enrico Sada [mailto:notifications@github.com]
Sent: Wednesday, April 13, 2016 4:32 PM
To: Microsoft/visualfsharp visualfsharp@noreply.github.com
Cc: Kevin Ransom Kevin.Ransom@microsoft.com
Subject: Re: [Microsoft/visualfsharp] Revert the revert of fssrgen (#1064)

In src/FSharpSource.targetshttps://github.com//pull/1064#discussion_r59643851:

@@ -230,6 +233,7 @@

 <DefineConstants>$(DefineConstants);NO_LOADER_OPTIMIZATION</DefineConstants>

 <DefineConstants>$(DefineConstants);SILVERLIGHT_COMPILER_FSHARP_CORE</DefineConstants>

 <DefineConstants>$(DefineConstants);I_DONT_KNOW_HOW_TO_DO_THIS_YET</DefineConstants>

• $(DefineConstants);NETSTANDARD1_5

the generated file from fssrgen contains an #if NETSTANDARD1_5 so the same file can work for both net46 and netstandard1.5 (dnxcore50 too, but now is useless)
NETSTANDARD1_5 it's the default define added for netstandard1.5 framework (like NET46 for .net 4.6)

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com//pull/1064/files/9e72d0c1b22f2a8d91e7e7e047def11637acb773#r59643851

[KevinRansom]

@enricosada ... can we make fssrgen a dotnet cli cmd. I would very much prefer for it to be a cross platform tool. Since it is an exe and has no real windows dependencies it would seem a good candidate.

Thanks

Kevin

[enricosada]

@KevinRansom i already added a dotnet fssrgen tool in https://github.com/fsprojects/FsSrGen and works as dotnet cli tool extensions (that mean, you do dotnet fssrgen and define inside tools)
It's just a matter of replace fssrgen with dotnet fssrgen, but that can be done later after this pr is merged and cli is stable (or -rc2)
I just dont want to break things with .net cli tools, if not necessary (atm everything work).
so my idea is:

1. replace lkg tools (fssrgen, fslexyacc, etc) with version downloaded from nuget packages
2. check everything works (tools can be a bit different, like fslexyacc, so testing)
3. replace new tools with xplat dotnet core version (each tools should support dotnet core)

[KevinRansom]

don just checked in an alternate for this.