-
Notifications
You must be signed in to change notification settings - Fork 847
Revert the revert of fssrgen #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
14de254
b852781
b90ee57
ce7ba17
9e72d0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| The copy of FSharp.Core in this directory is version 2.0.50726.900, required by FSharp.SRGen.Build.Tasks.dll and other legacy Power Pack libraries in the parent directory. | ||
| The copy of FSharp.Core in this directory is version 2.0.50726.900, required by legacy Power Pack libraries in the parent directory. | ||
|
|
||
| This copy of FSharp.Core.dll should not be referenced as an LKG, it is present merely as a workaround to enable the legacy libraries to work without needing to update the GAC. |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -132,6 +132,9 @@ | |
| <FsCheckVersion>2.0.3</FsCheckVersion> | ||
| <FsCheckFullVersion>2.0.3.0</FsCheckFullVersion> | ||
| <FsCheckLibDir>$(FSharpSourcesRoot)\..\packages\FsCheck.$(FsCheckVersion)\lib\</FsCheckLibDir> | ||
| <FsSrGenVersion>3.0.0</FsSrGenVersion> | ||
| <FsSrGenBuildTasksVersion>3.0.0</FsSrGenBuildTasksVersion> | ||
| <FsSrGenToolPath>$(FSharpSourcesRoot)\..\packages\fssrgen.$(FsSrGenVersion)\lib\net46</FsSrGenToolPath> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- v2.0-specific flags --> | ||
|
|
@@ -230,6 +233,7 @@ | |
| <DefineConstants>$(DefineConstants);NO_LOADER_OPTIMIZATION</DefineConstants> | ||
| <DefineConstants>$(DefineConstants);SILVERLIGHT_COMPILER_FSHARP_CORE</DefineConstants> | ||
| <DefineConstants>$(DefineConstants);I_DONT_KNOW_HOW_TO_DO_THIS_YET</DefineConstants> | ||
| <DefineConstants>$(DefineConstants);NETSTANDARD1_5</DefineConstants> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is this define used?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the generated file from fssrgen contains an
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the generated code need to be different? From: Enrico Sada [mailto:notifications@github.com] In src/FSharpSource.targetshttps://github.com//pull/1064#discussion_r59643851:
the generated file from fssrgen contains an #if NETSTANDARD1_5 so the same file can work for both net46 and netstandard1.5 (dnxcore50 too, but now is useless) — |
||
| <TargetFrameworkProfile>profile7</TargetFrameworkProfile> <!-- We are currently directly referencing corefx assemblies, so profile7 is not really true --> | ||
| <ImplicitlyExpandTargetFramework>false</ImplicitlyExpandTargetFramework> <!-- To stop msbuild being helpfull and referencing the dlls for the profile --> | ||
| </PropertyGroup> | ||
|
|
@@ -826,7 +830,6 @@ | |
| <CompileDependsOn>ValidateConfiguration;$(CompileDependsOn);CustomCopyLocalFiles</CompileDependsOn> | ||
| <RootNamespace></RootNamespace> | ||
| <DocumentationFile>$(OutputPath)$(AssemblyName).xml</DocumentationFile> | ||
| <EnsureThereAreNoUnusedFsSrGenResources>false</EnsureThereAreNoUnusedFsSrGenResources> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name="ValidateConfiguration"> | ||
|
|
@@ -865,7 +868,7 @@ | |
| </CreateItem> | ||
| </Target> | ||
|
|
||
| <Import Project="..\lkg\FSharp-$(LkgVersion)\bin\FSharp.SRGen.targets" /> | ||
| <Import Project="..\packages\FSharp.SRGen.Build.Tasks.$(FsSrGenBuildTasksVersion)\content\FSharp.SRGen.targets" /> | ||
| <Import Project="Microbuild.Settings.targets" /> | ||
|
|
||
| <Target Name="ReorderCompileItems" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I really need to do something about this one, I thought I had got rid of it. The: "I_DONT_KNOW_HOW_TO_DO_THIS_YET"