Some examples for the List module. Small refactor of the String examples as requested by reviewer. #12134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
requested changes
Sep 14, 2021
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Left a bunch of comments :)))
Nearly all the examples are really great. I think needs some additional work for fold/foldBack
src/fsharp/FSharp.Core/list.fsi
Outdated
| /// | ||
| /// <example id="countBy-example-1"> | ||
| /// <code lang="fsharp"> | ||
| /// let isEven x = 0 = x % 2 |
Contributor
There was a problem hiding this comment.
This example feels a bit too mathematical (modulus) - better to be getting a statistic of some kind, e.g. count a list of lists by length, or strings by number of occurrences of characters
Contributor
Author
There was a problem hiding this comment.
Counted the letters in the ['H'; 'a'; 'p'; 'p'; 'i'; 'n'; 'e'; 's'; 's'] . Do you think that will be better to use "Happiness".ToCharArray() |> Array.toList ?
Contributor
Author
|
Thank you Don for review! |
dsyme
reviewed
Sep 14, 2021
dsyme
reviewed
Sep 14, 2021
dsyme
reviewed
Sep 14, 2021
Contributor
|
Just a few more comments |
dsyme
approved these changes
Sep 14, 2021
dsyme
approved these changes
Sep 14, 2021
Contributor
|
Thanks so much. Pushed some cosmetic changes, when it's green it'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some examples for the List module. Small refactor of the String examples as requested by reviewer.
Tracking issue: #12124