-
Notifications
You must be signed in to change notification settings - Fork 847
CheckDeclarations: don't report environment for checked top-level module #12865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CheckDeclarations: don't report environment for checked top-level module #12865
Conversation
063a57f to
eaf6006
Compare
|
OK, the failing test shows an actual regression related to recursive modules. I'm looking into it. |
|
Hm, for some reason CI doesn't restart on PR reopening... |
093b199 to
ff3ec14
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@DedSec256 @vzarytovskii Do you have any idea why xml doc tests could fail in this PR? |
|
Huh, that's some weird failures. It does not ring a bell to me, I will try to figure it out tomorrow morning. Edit: it also seems to be failing for the same reason in #12872 |
ff3ec14 to
bd9f700
Compare
|
It's ready. |
Fixes completion for
Fieldfield at the caret position:Prior to this change, another name environment for the anon module is reported after it's been checked, and this environment overwrites an environment that should've been used inside the module. Reporting such an environment is needed for analysis of subsequent module declarations in the outer scope but breaks editor features inside top-level modules when reported for its own range.