Skip to content

Conversation

@DedSec256
Copy link
Contributor

@DedSec256 DedSec256 commented Mar 24, 2022

It seems that in

if allErrors || fileName = mainInputFileName || fileName = TcGlobals.DummyFileNameForRangesWithoutASpecificLocation then

check fileName = mainInputFileName is not passing
since one of them has the form /home/user/Test.fsx and the other one is normalized to the form C:/home/user/Test.fsx

due to which some diagnostics may not be reported (like here #12865 (comment))

@DedSec256 DedSec256 changed the title Fix tests [WIP] Fix tests Mar 24, 2022
@auduchinok
Copy link
Member

auduchinok commented Mar 25, 2022

@vzarytovskii We weren't able to find out why it hadn't been failing before, but for some reason it started failing even locally in main, so I assume it'll fix the failures in #12865.

@vzarytovskii vzarytovskii merged commit bab88e4 into dotnet:main Mar 25, 2022
@vzarytovskii
Copy link
Member

@vzarytovskii We weren't able to find out why it hadn't been failing before, but for some reason it started failing even locally in main, so I assume it'll fix the failures in #12865.

Thanks for fixing it. It is indeed weird why it wasn't failing before. I will find some time to dig into it.

@DedSec256 DedSec256 deleted the ber.a/testFix branch March 25, 2022 12:56
charlesroddie pushed a commit to charlesroddie/fsharp that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants