Fix: open shadowcopy file stream for RW #13692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
reviewed
Aug 15, 2022
src/Compiler/Utilities/FileSystem.fs
Outdated
| // We want to use mmaped files only when: | ||
| // - Opening large binary files (no need to use for source or resource files really) | ||
| // - Running on mono, since its MemoryMappedFile implementation throws when "mapName" is not provided (is null). | ||
| // - Not running on mono, since its MemoryMappedFile implementation throws when "mapName" is not provided (is null). |
Contributor
There was a problem hiding this comment.
We don't do mono checks any longer the comment can go by by.
Contributor
There was a problem hiding this comment.
Also we don't do shadowcopy on coreclr, we probably need to think about what to do about that.
KevinRansom
approved these changes
Aug 15, 2022
Contributor
|
This is great! Let me try if it’s now possible to use a recent FSharp.Core.dll with VS (this failed only with Framework). |
Member
Author
Well, this was not inserted into VS or SDK yet, so you will have to specify the path tho the compiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12239