Skip to content

Fix: open shadowcopy file stream for RW #13692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 2 commits into from
Aug 16, 2022
Merged

Fix: open shadowcopy file stream for RW #13692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
795027e
Fix: open shadowcopy file stream for RW
vzarytovskii Aug 15, 2022
11d9b08
Update comment
vzarytovskii Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Compiler/Utilities/FileSystem.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,8 +530,6 @@ type DefaultFileSystem() as this =

// We want to use mmaped files only when:
// - Opening large binary files (no need to use for source or resource files really)
// - Running on mono, since its MemoryMappedFile implementation throws when "mapName" is not provided (is null).
// (See: https://github.com/mono/mono/issues/10245)

if not useMemoryMappedFile then
fileStream :> Stream
Expand All @@ -542,12 +540,12 @@ type DefaultFileSystem() as this =
MemoryMappedFile.CreateNew(
null,
length,
MemoryMappedFileAccess.Read,
MemoryMappedFileAccess.ReadWrite,
MemoryMappedFileOptions.None,
HandleInheritability.None
)

use stream = mmf.CreateViewStream(0L, length, MemoryMappedFileAccess.Read)
use stream = mmf.CreateViewStream(0L, length, MemoryMappedFileAccess.ReadWrite)
fileStream.CopyTo(stream)
fileStream.Dispose()
mmf
Expand Down
1 change: 1 addition & 0 deletions tests/projects/Sample_ConsoleApp_FileSystemTests/Program.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[<EntryPoint>] let main _ = 0
24 changes: 24 additions & 0 deletions tests/projects/Sample_ConsoleApp_FileSystemTests/Sample_ConsoleApp_net7.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
</PropertyGroup>

<PropertyGroup>
<DotnetFscCompilerPath>$(MSBuildThisFileDirectory)../../../artifacts/bin/fsc/Debug/net6.0/fsc.dll</DotnetFscCompilerPath>
<Fsc_DotNET_DotnetFscCompilerPath>$(MSBuildThisFileDirectory)../../../artifacts/bin/fsc/Debug/net6.0/fsc.dll</Fsc_DotNET_DotnetFscCompilerPath>
<FSharpPreferNetFrameworkTools>False</FSharpPreferNetFrameworkTools>
<FSharpPrefer64BitTools>True</FSharpPrefer64BitTools>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="FSharp.Core" Version="3.0.2" />
</ItemGroup>

<ItemGroup>
<Compile Include="Program.fs" />
</ItemGroup>

</Project>