Skip to content

Conversation

@psfinaki
Copy link
Contributor

closes #14369

Before:

keywords_before.mp4

After:

keywords_after.mp4

The implementation is based on the Roslyn approach here. Looking at their resources, it doesn't seem like there was much thought put into concrete keywords so I also just copypasted our string resources.

Note that VS is smart-ish in keyword processing, in that it doesn't require a full match, and IMO provides a good option search experience.

@psfinaki psfinaki requested a review from a team as a code owner November 22, 2022 13:57
@psfinaki psfinaki enabled auto-merge (squash) November 22, 2022 14:47
@T-Gro
Copy link
Member

T-Gro commented Nov 22, 2022

Did you try in any other language besides English?
Wonder if the search works the same across localized settings.

@psfinaki
Copy link
Contributor Author

Did you try in any other language besides English? Wonder if the search works the same across localized settings.

@T-Gro I played with this a bit - I guess it does work somehow, e.g. this is for C# which is already translated to Czech:
image

But you know, once you remove a háček or a čárka, Visual Studio is lost, so this is all in vain anyway :D

@psfinaki
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki merged commit 43f2fc0 into dotnet:main Nov 23, 2022
@psfinaki psfinaki deleted the psfinaki/keywords branch November 23, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add keywords for F# settings in VS options

5 participants