Use GetFullPath when determining the full path in command line options#7376
Merged
cartermp merged 1 commit intodotnet:masterfrom Aug 9, 2019
cartermp:fix-gtd-forward-slash
Merged
Use GetFullPath when determining the full path in command line options#7376cartermp merged 1 commit intodotnet:masterfrom cartermp:fix-gtd-forward-slash
cartermp merged 1 commit intodotnet:masterfrom
cartermp:fix-gtd-forward-slash
Conversation
TIHan
approved these changes
Aug 9, 2019
Contributor
TIHan
left a comment
There was a problem hiding this comment.
After this, we should cherry pick it into release/dev16.3 - looks good. When we tested, it seems to fixed the issue with navigation.
This was referenced Aug 9, 2019
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4016, #5521, #4446
This is @chadunit's idea here: #4016 (comment)
Quick writeup:
rangetype based on the file name that the editor host supplies.rangetypes created won't match actualranges that live on a symbol