Netstandard fsharp core only#7463
Closed
KevinRansom wants to merge 16 commits intodotnet:release/fsharp5from
Closed
Netstandard fsharp core only#7463KevinRansom wants to merge 16 commits intodotnet:release/fsharp5from
KevinRansom wants to merge 16 commits intodotnet:release/fsharp5from
Conversation
cartermp
reviewed
Aug 29, 2019
KevinRansom
force-pushed
the
netstandardfsharpcoreonly
branch
from
b51f9b2 to
d86e822
Compare
KevinRansom
force-pushed
the
netstandardfsharpcoreonly
branch
2 times, most recently
from
79ec6f5 to
01f6746
Compare
brettfo
reviewed
Sep 13, 2019
tests/fsharp/test-framework.fs
Outdated
Member
There was a problem hiding this comment.
This line can be pulled out of the #if NET472 block since it's the same for both scenarios.
brettfo
reviewed
Sep 13, 2019
Member
There was a problem hiding this comment.
Note for future work, it might be a good idea to convert these tools to netcoreapp2.1 (or 3.0).
brettfo
reviewed
Sep 13, 2019
...oMultipleProjects/SameFileBelongsToMultipleProjects/SameFileBelongsToMultipleProjects.fsproj
Outdated
Show resolved
Hide resolved
brettfo
approved these changes
Sep 13, 2019
cartermp
approved these changes
Sep 20, 2019
Contributor
|
Since #7462 is merged, is this mergable? CI is green. |
Co-Authored-By: Phillip Carter <pcarter@fastmail.com>
KevinRansom
force-pushed
the
netstandardfsharpcoreonly
branch
from
fde80b7 to
dee238e
Compare
Contributor
Author
|
I will do this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For FSharp.Core version 5.0 we want to have only a single netstandard2.0. Since the surface area of the netstandard 2.0 and the desktop version of FSharp.Core are identical.
This PR, updates the build fixes the packaging.
Until this PR: #7462 is fixed, the --standalone tests will fail.
TBD:
In order for existing command line builds to work unchanged, we are going to have to automagically reference these assemblies:
I have emotional problems with that, but changing that would remove a bunch of test changes in this PR where we reference those assemblies, so I suppose I will get over my issues.