-
Notifications
You must be signed in to change notification settings - Fork 853
Netstandard fsharp core only #7463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
KevinRansom
wants to merge
16
commits into
dotnet:release/fsharp5
from
KevinRansom:netstandardfsharpcoreonly
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a78bba6
temp
KevinRansom ec33ced
temp
KevinRansom 4234b95
Only build and test NetStandard 2.0 FSharp.Core
KevinRansom c3d2dca
Update src/fsharp/FSharp.Core/FSharp.Core.fsproj
KevinRansom edd38ca
temp
KevinRansom 39b54bb
tests
KevinRansom 5a015ef
temp
KevinRansom 40c3625
update MultiProjectAnalysisTests
KevinRansom a1905cb
Fix GenericComparison fsharpqa tests
KevinRansom e09e87a
Fix Optimizations\ForLoop bsls
KevinRansom f894a3c
Fix more
KevinRansom 01c4eba
interactive session misc tests
KevinRansom c2cb24b
update tests
KevinRansom 295f920
Update ProjectAnalysisTests.fs
KevinRansom 84914b7
temp
KevinRansom dee238e
fix c# compile
KevinRansom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -164,7 +164,7 @@ let config configurationName envVars = | |
| #if NET472 | ||
| let fscArchitecture = "net472" | ||
| let fsiArchitecture = "net472" | ||
| let fsharpCoreArchitecture = "net45" | ||
| let fsharpCoreArchitecture = "netstandard2.0" | ||
|
||
| let fsharpBuildArchitecture = "net472" | ||
| let fsharpCompilerInteractiveSettingsArchitecture = "net472" | ||
| #else | ||
|
|
@@ -179,8 +179,8 @@ let config configurationName envVars = | |
| let artifactsBinPath = artifactsPath ++ "bin" | ||
| let coreClrRuntimePackageVersion = "3.0.0-preview-27318-01" | ||
| let csc_flags = "/nologo" | ||
| let fsc_flags = "-r:System.Core.dll --nowarn:20 --define:COMPILED" | ||
| let fsi_flags = "-r:System.Core.dll --nowarn:20 --define:INTERACTIVE --maxerrors:1 --abortonerror" | ||
| let fsc_flags = "-r:System --nowarn:20 --define:COMPILED" | ||
| let fsi_flags = "-r:System --nowarn:20 --define:INTERACTIVE --maxerrors:1 --abortonerror" | ||
| let Is64BitOperatingSystem = WindowsPlatform.Is64BitOperatingSystem envVars | ||
| let architectureMoniker = if Is64BitOperatingSystem then "x64" else "x86" | ||
| let CSC = requireFile (packagesDir ++ "Microsoft.Net.Compilers" ++ "2.7.0" ++ "tools" ++ "csc.exe") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.