Fix FsLex/FsYacc output #9877
Merged
Fix FsLex/FsYacc output #9877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
reviewed
Aug 5, 2020
Contributor
|
Is this the opportune moment to also fix that fslex/yacc is run when you compile the solution from within visual studio? (maybe it's only needed to add it to the solution as included file, so that it's considered "dirty"? Currently, a change to the fsl or fsy file doesn't trigger a recompile, and only running a full build from commandline can be used as workaround). |
Contributor
Author
|
@abelbraaksma , I didn't know that. I guess I can take a look, but I will do that in a separate PR |
cartermp
approved these changes
Aug 5, 2020
Contributor
Author
|
@abelbraaksma , just so you know, lex/yacc not regenerating those files when built in vs is doing my brain in. Kevin |
This was referenced Aug 11, 2020
Contributor
|
@KevinRansom, sorry about your brain 😆, let me help. I've created a tracking issue #9920 and fixed it in #9918 along with a few other nits. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the build we use FSLEX and FSYACC to create files included in the FSharp.Compiler.Private.dll
We build this dll several times, net472, netcoreapp3.1 and proto. The existing build writes all of the files to the same location.
This fix writes the generated files to the intermediateoutputpath/targetframework directory. To ensure that each build is independent.