-
Notifications
You must be signed in to change notification settings - Fork 847
Fix showing pars.fs, lex.fs output in solution view, fix auto-generating FsLex/FsYacc output on change, add fsl and fsy to solution view #9918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cartermp
merged 4 commits into
dotnet:master
from
abelbraaksma:fix-missing-lex-fs-pars-fs
Aug 12, 2020
Merged
Fix showing pars.fs, lex.fs output in solution view, fix auto-generating FsLex/FsYacc output on change, add fsl and fsy to solution view #9918
cartermp
merged 4 commits into
dotnet:master
from
abelbraaksma:fix-missing-lex-fs-pars-fs
Aug 12, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
Since no code has changed, this will be green soon ;). Here's a summary of what's changed w.r.t. experience:
|
vzarytovskii
approved these changes
Aug 11, 2020
Contributor
Author
|
@cartermp, I think this is ready for merging, though @KevinRansom maybe you could have a quick look as well? You recently made changes in the same area... |
cartermp
approved these changes
Aug 12, 2020
Contributor
cartermp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…ing FsLex/FsYacc output on change, add fsl and fsy to solution view (dotnet#9918) * Fix showing pars.fs, lex.fs, pppars.fs and pplex.fs in sln * Also fix showing ilpars.fs and illex.fs * Fix automatic run of fslex/fsyacc when file is dirty * Same for AbsIL lex/yacc output, fix order in sln expl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Fixes #9919
Also fixes #9920
This fixes an issue partially caused by #9877, partially already present prior to that, which hid certain linked files because the
<Link>element infsprojdidn't point to the solution folder, but to the source folder where the linked file came from.Also fixes the somewhat annoying situation that when you change an
fslorfsyfile, it doesn't get compiled. I've taken the liberty of slightly changing the link-structure (physical structure remains the same). By adding<None Includefor those files, Visual Studio tracks them and MSBuild builds them.Before (and after #9877):

After this change:

(note: I wanted to place the
*.fsl/fsyinput/output closer together, but the FsYacc and FsLex build tasks prevent this from happening. I.e., try movingUnicodeLexing.fsiup: you can't. I think this is the next best thing, let me know what you think ;) ).Build now clearly shows that FsYacc (or FsLex) is run:
